Skip to content

Removed unnecessary user notifications for version conflict exception #1413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ask-kamal-nayan
Copy link

@ask-kamal-nayan ask-kamal-nayan commented Apr 28, 2025

Description

The manual snapshot policy management system needs modification to prevent false alarm notifications caused by internal version conflict exceptions during concurrent snapshot operations.
GitHub Issue Reference
Current Behavior:

  • Snapshot policy creates/deletes snapshots via cron jobs
  • State updates are made to .ism-config system index
  • Race conditions occur during concurrent operations which cause VersionConflictEngineException
  • Manual snapshot happens as expected from users.
  • Users receive notifications for all exceptions, including internal version conflicts
  • False alarms are triggered for non-user-impacting issues

Proposed Changes:
Modify exception handling to suppress notifications for VersionConflictEngineException just log this as error message.
Maintain notifications for all other exception type

Related Issues

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…s in Snapshot Management

Signed-off-by: Kamal Nayan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant