fix: don't call Alias API if aliasActions are empty #1489
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If index has only a single alias that has been rolled over on, copyAlias() throws exception, becuse it tries to call Alias API with empty actions param. Signed-off-by: tender_barbarian <[email protected]>
tender-barbarian
requested review from
Hailong-am,
bowenlan-amzn,
shiv0408,
soosinha,
tandonks and
vikasvb90
as code owners
|
could you check the ci failure? |
Yeah I'm not sure what's that about. Doesn't seem to be related to my change... |
|
Indeed looks like main branch pipeline is failing. I've executed a test branch with just a change to readme and it's failing as well: tender-barbarian#1 An upstream issue perhaps? |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1489 +/- ##
==========================================
- Coverage 76.22% 76.11% -0.11%
==========================================
Files 375 375
Lines 18773 18775 +2
Branches 2366 2367 +1
==========================================
- Hits 14310 14291 -19
- Misses 3225 3253 +28
+ Partials 1238 1231 -7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If index has only a single alias that has been rolled over on, copyAlias() throws exception, becuse it tries to call Alias API with empty actions param.
Related Issues
Resolves #1488
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.