Skip to content

Use optionalField for creation in ExplainSMPolicy serialization #1507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+7 −1
Open

Use optionalField for creation in ExplainSMPolicy serialization #1507

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d0d9f83
Use optionalField for creation in ExplainSMPolicy serialization
Tarun-kishore Oct 13, 2025
5079606
Adding Version check
Tarun-kishore Oct 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/main/kotlin/org/opensearch/indexmanagement/snapshotmanagement/model/ExplainSMPolicy.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@

package org.opensearch.indexmanagement.snapshotmanagement.model

import org.opensearch.Version
import org.opensearch.core.common.io.stream.StreamInput
import org.opensearch.core.common.io.stream.StreamOutput
import org.opensearch.core.common.io.stream.Writeable
Expand Down Expand Up @@ -36,10 +37,15 @@ data class ExplainSMPolicy(
override fun toXContent(builder: XContentBuilder, params: ToXContent.Params): XContentBuilder {
metadata?.let {
builder
.field(SMMetadata.CREATION_FIELD, it.creation)
.optionalField(SMMetadata.DELETION_FIELD, it.deletion)
.field(SMMetadata.POLICY_SEQ_NO_FIELD, it.policySeqNo)
.field(SMMetadata.POLICY_PRIMARY_TERM_FIELD, it.policyPrimaryTerm)

if (Version.CURRENT > Version.V_3_3_0) {
builder.optionalField(SMMetadata.CREATION_FIELD, it.creation)
} else {
builder.field(SMMetadata.CREATION_FIELD, it.creation)
}
}
return builder.field(SMPolicy.ENABLED_FIELD, enabled)
}
Expand Down