Skip to content

Conversation

cwperks
Copy link
Member

@cwperks cwperks commented Feb 25, 2025

Description

This PR is a small change to only download the demo certs when run with -Dsecurity.enabled=true. If security is not enabled, downloading demo certs is not necessary.

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Feb 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.67%. Comparing base (fa0f422) to head (30057a1).
Report is 1 commits behind head on main.

❌ Your project status has failed because the head coverage (37.67%) is below the target coverage (75.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #737   +/-   ##
=========================================
  Coverage     37.67%   37.67%           
  Complexity      135      135           
=========================================
  Files            22       22           
  Lines          1189     1189           
  Branches        109      109           
=========================================
  Hits            448      448           
  Misses          704      704           
  Partials         37       37           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cwperks cwperks merged commit 740d707 into opensearch-project:main Feb 25, 2025
17 of 18 checks passed
@github-project-automation github-project-automation bot moved this from 👀 In Review to ✅ Done in Engineering Effectiveness Board Feb 25, 2025
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 25, 2025
…rue (#737)

* Only download demo certs when integTest run with -Dsecurity.enabled=true

Signed-off-by: Craig Perkins <[email protected]>

* Make consistent with security.enabled

Signed-off-by: Craig Perkins <[email protected]>

---------

Signed-off-by: Craig Perkins <[email protected]>
(cherry picked from commit 740d707)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 25, 2025
…rue (#737)

* Only download demo certs when integTest run with -Dsecurity.enabled=true

Signed-off-by: Craig Perkins <[email protected]>

* Make consistent with security.enabled

Signed-off-by: Craig Perkins <[email protected]>

---------

Signed-off-by: Craig Perkins <[email protected]>
(cherry picked from commit 740d707)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
cwperks pushed a commit that referenced this pull request Feb 25, 2025
…rue (#737) (#739)

* Only download demo certs when integTest run with -Dsecurity.enabled=true



* Make consistent with security.enabled



---------


(cherry picked from commit 740d707)

Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
cwperks pushed a commit that referenced this pull request Feb 25, 2025
…rue (#737) (#740)

* Only download demo certs when integTest run with -Dsecurity.enabled=true



* Make consistent with security.enabled



---------


(cherry picked from commit 740d707)

Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

2 participants