-
Notifications
You must be signed in to change notification settings - Fork 94
Only download demo certs when integTest run with -Dsecurity.enabled=true #737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only download demo certs when integTest run with -Dsecurity.enabled=true #737
Conversation
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
❌ Your project status has failed because the head coverage (37.67%) is below the target coverage (75.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #737 +/- ##
=========================================
Coverage 37.67% 37.67%
Complexity 135 135
=========================================
Files 22 22
Lines 1189 1189
Branches 109 109
=========================================
Hits 448 448
Misses 704 704
Partials 37 37 ☔ View full report in Codecov by Sentry. |
…rue (#737) * Only download demo certs when integTest run with -Dsecurity.enabled=true Signed-off-by: Craig Perkins <[email protected]> * Make consistent with security.enabled Signed-off-by: Craig Perkins <[email protected]> --------- Signed-off-by: Craig Perkins <[email protected]> (cherry picked from commit 740d707) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…rue (#737) * Only download demo certs when integTest run with -Dsecurity.enabled=true Signed-off-by: Craig Perkins <[email protected]> * Make consistent with security.enabled Signed-off-by: Craig Perkins <[email protected]> --------- Signed-off-by: Craig Perkins <[email protected]> (cherry picked from commit 740d707) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…rue (#737) (#739) * Only download demo certs when integTest run with -Dsecurity.enabled=true * Make consistent with security.enabled --------- (cherry picked from commit 740d707) Signed-off-by: Craig Perkins <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…rue (#737) (#740) * Only download demo certs when integTest run with -Dsecurity.enabled=true * Make consistent with security.enabled --------- (cherry picked from commit 740d707) Signed-off-by: Craig Perkins <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Description
This PR is a small change to only download the demo certs when run with
-Dsecurity.enabled=true
. If security is not enabled, downloading demo certs is not necessary.Check List
--signoff
.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.