Use java-agent Gradle plugin to support phasing off SecurityManager usage in favor of Java Agent #762
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prudhvigodithi
requested review from
cwperks,
dbwiddis,
joshpalis,
kaituo,
saratvemulapalli and
vibrantvarun
as code owners
66 tasks
There was a problem hiding this comment.
@prudhvigodithi I think you need to remove those previous changes as well?
Thanks.
Codecov ReportAll modified and coverable lines are covered by tests ✅
❌ Your project status has failed because the head coverage (37.67%) is below the target coverage (75.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #762 +/- ##
=========================================
Coverage 37.67% 37.67%
Complexity 135 135
=========================================
Files 22 22
Lines 1189 1189
Branches 109 109
=========================================
Hits 448 448
Misses 704 704
Partials 37 37 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Thanks @peterzhuamazon just pushed the change. |
cwperks
previously approved these changes
Apr 12, 2025
There was a problem hiding this comment.
Thank you @prudhvigodithi ! This is much cleaner with the tooling inherited from the core.
github-project-automation
bot
moved this to 👀 In Review
in Engineering Effectiveness Board
peterzhuamazon
previously approved these changes
Apr 12, 2025
Signed-off-by: Prudhvi Godithi <[email protected]>
prudhvigodithi
dismissed stale reviews from peterzhuamazon and cwperks
via
9653d76
cwperks
approved these changes
Apr 12, 2025
peterzhuamazon
approved these changes
Apr 12, 2025
5 tasks
prudhvigodithi
merged commit 5a5e982
into
opensearch-project:main
13 of 14 checks passed
github-project-automation
bot
moved this from 👀 In Review
to ✅ Done
in Engineering Effectiveness Board
This was referenced Apr 14, 2025
Merged
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since the PR opensearch-project/OpenSearch#17900 is now merged we can just apply the gradle plugin, reverting #759.
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.