Get a list of all jobs bug fix #791
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jeremy Dupras <[email protected]>
Jeremydupras
requested review from
dbwiddis,
joshpalis,
kaituo,
saratvemulapalli and
vibrantvarun
as code owners
|
@Jeremydupras can you add more to the PR description with what this PR is addressing |
|
Added additional reasoning in the PR description. |
|
@Jeremydupras can we add a test for this fix as well? |
cwperks
reviewed
Jul 3, 2025
|
|
||
| if (jobInfo.getActualPreviousExecutionTime() != null) { | ||
| jobDetails.put("last_execution_time", jobInfo.getActualPreviousExecutionTime()); | ||
| jobDetails.put("last_execution_time", jobInfo.getActualPreviousExecutionTime().toString()); |
There was a problem hiding this comment.
I think we should use a DateTime formatter similar to core: https://github.com/opensearch-project/OpenSearch/blob/main/server/src/main/java/org/opensearch/rest/action/cat/RestIndicesAction.java#L1073
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Converts instant to string.
Instant objects are not able to be serialized into the jobs map and cause the jobScheduler to crash. Converting to a string allows the Instant object to be added to the jobs map. These two line now match the other Instant Objects which are out into the jobs map.
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.