Make Lock service not final #792
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is a non-breaking change that is a precursor for #714
Essentially, there are plugins in the OpenSearch ecosystem that are directly instantiating the LockService class from JS SPI and I am seeking to forbid this in future versions of OpenSearch in favor of using dependency injection and only instantiating within the Job Scheduler.
Ultimately, I plan to convert the LockService to an interface.
The problem with having this class marked as final, is that I cannot replace usages like https://github.com/opensearch-project/geospatial/blob/506b38356e9ff79ce5dd3ac6871f4e871af6b2aa/src/test/java/org/opensearch/geospatial/ip2geo/common/Ip2GeoLockServiceTests.java#L35 because it requires mocking.
I would like to remove
final
as a modifier (only in the interim) to be able to replace existing places where the LockService is instantiated and then fully replace it with an interface.Check List
--signoff
.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.