Skip to content

Conversation

cwperks
Copy link
Member

@cwperks cwperks commented Jul 8, 2025

Description

Currently, when I try to run a command like ./gradlew :opensearch-job-scheduler-sample-extension:integTest --tests SampleJobRunnerRestIT.testJobUpdateWithRescheduleJobThenListJobs -x :test -x :integTest it will always run all top-level unit tests and integ tests even though I explicitly passed a skip flag.

JS has a fairly complex gradle configuration the sets a dependency from integTest -> bundle -> bundlePlugin which creates this chain of task dependencies. It also has a dependency on java-rest-test that appears to be unused.

I am raising this PR to break this chain of dependencies which allows a developer to now run a single unit test without having to specify to skip any tasks.

With the changes in this PR, a command like ./gradlew :opensearch-job-scheduler-sample-extension:integTest --tests SampleJobRunnerRestIT.testJobUpdateWithRescheduleJobThenListJobs will run a single test.

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Jul 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 33.76%. Comparing base (906af8b) to head (0ad9335).
Report is 1 commits behind head on main.

❌ Your project status has failed because the head coverage (33.76%) is below the target coverage (75.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #794   +/-   ##
=========================================
  Coverage     33.76%   33.76%           
  Complexity      143      143           
=========================================
  Files            29       29           
  Lines          1380     1380           
  Branches        132      132           
=========================================
  Hits            466      466           
  Misses          877      877           
  Partials         37       37           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cwperks cwperks merged commit c9857f0 into opensearch-project:main Jul 9, 2025
16 of 17 checks passed
@github-project-automation github-project-automation bot moved this from 👀 In Review to ✅ Done in Engineering Effectiveness Board Jul 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

2 participants