-
Notifications
You must be signed in to change notification settings - Fork 94
Add new Github workflow to run sample plugin tests in cluster with multiple nodes #795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Craig Perkins <[email protected]>
- name: Run Job-scheduler Integ Tests with Multiple Nodes | ||
run: | | ||
echo "Running integ tests with multiple nodes..." | ||
./gradlew :opensearch-job-scheduler-sample-extension:integTest -PnumNodes=2 No newline at end of file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, may be we need a matrix to run by default and run with -PnumNodes=2
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ya that's a good idea. Some integTests in the root project run with multiple nodes and have their test suites annotated accordingly (example).
The sample plugin is a useful tool for running integ tests with an actual plugin that schedules work so I think the integ tests can be expanded upon there esp as we add more functionality to the job scheduler.
Signed-off-by: Craig Perkins <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
❌ Your project status has failed because the head coverage (33.76%) is below the target coverage (75.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #795 +/- ##
=========================================
Coverage 33.76% 33.76%
Complexity 143 143
=========================================
Files 29 29
Lines 1380 1380
Branches 132 132
=========================================
Hits 466 466
Misses 877 877
Partials 37 37 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Description
Add new Github workflow to run sample plugin tests in cluster with multiple nodes
Check List
--signoff
.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.