Skip to content

Conversation

cwperks
Copy link
Member

@cwperks cwperks commented Jul 9, 2025

Description

Add new Github workflow to run sample plugin tests in cluster with multiple nodes

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

prudhvigodithi
prudhvigodithi previously approved these changes Jul 9, 2025
- name: Run Job-scheduler Integ Tests with Multiple Nodes
run: |
echo "Running integ tests with multiple nodes..."
./gradlew :opensearch-job-scheduler-sample-extension:integTest -PnumNodes=2 No newline at end of file
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, may be we need a matrix to run by default and run with -PnumNodes=2.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ya that's a good idea. Some integTests in the root project run with multiple nodes and have their test suites annotated accordingly (example).

The sample plugin is a useful tool for running integ tests with an actual plugin that schedules work so I think the integ tests can be expanded upon there esp as we add more functionality to the job scheduler.

Signed-off-by: Craig Perkins <[email protected]>
Copy link

codecov bot commented Jul 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 33.76%. Comparing base (c9857f0) to head (ba0ca91).
Report is 1 commits behind head on main.

❌ Your project status has failed because the head coverage (33.76%) is below the target coverage (75.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #795   +/-   ##
=========================================
  Coverage     33.76%   33.76%           
  Complexity      143      143           
=========================================
  Files            29       29           
  Lines          1380     1380           
  Branches        132      132           
=========================================
  Hits            466      466           
  Misses          877      877           
  Partials         37       37           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cwperks cwperks changed the title Add new GHA to run sample plugin tests in cluster with multiple nodes Add new Github workflow to run sample plugin tests in cluster with multiple nodes Jul 9, 2025
@cwperks cwperks merged commit d995ed2 into opensearch-project:main Jul 9, 2025
16 of 18 checks passed
@github-project-automation github-project-automation bot moved this from 👀 In Review to ✅ Done in Engineering Effectiveness Board Jul 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

3 participants