Support defining IntervalSchedule in seconds #796
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
cwperks
requested review from
dbwiddis,
joshpalis,
kaituo,
prudhvigodithi,
saratvemulapalli and
vibrantvarun
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
❌ Your project status has failed because the head coverage (33.54%) is below the target coverage (75.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #796 +/- ##
=========================================
Coverage 33.54% 33.54%
Complexity 143 143
=========================================
Files 29 29
Lines 1389 1389
Branches 132 132
=========================================
Hits 466 466
Misses 886 886
Partials 37 37 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
Merged
5 tasks
kaituo
approved these changes
Jul 11, 2025
github-project-automation
bot
moved this to 👀 In Review
in Engineering Effectiveness Board
github-project-automation
bot
moved this from 👀 In Review
to ✅ Done
in Engineering Effectiveness Board
5 tasks
Jeremydupras
pushed a commit
to Jeremydupras/job-scheduler
that referenced
this pull request
Aug 20, 2025
* WIP on allowing interval schedule to operate in seconds Signed-off-by: Craig Perkins <[email protected]> * Support defining IntervalSchedule in seconds Signed-off-by: Craig Perkins <[email protected]> * Use seconds in bwc test Signed-off-by: Craig Perkins <[email protected]> * Update runThenListJobs test Signed-off-by: Craig Perkins <[email protected]> * Consistent create watcher job Signed-off-by: Craig Perkins <[email protected]> --------- Signed-off-by: Craig Perkins <[email protected]> Signed-off-by: Jeremy Dupras <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR contains an enhancement that allows user's to define an interval schedule in seconds. In order to adequately have jobs running in seconds, a cluster admin must set
plugins.jobscheduler.sweeper.periodalso to a value in seconds as this is the frequency at which the jobs are swept.One of the primary benefits of this PR is it drastically reduces the time for integ tests in the sample plugin bc we can now wait seconds instead of minutes to verify behavior.
This PR also refactors the integ tests in the sample plugin for readability.
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.