Skip to content

Conversation

Jeremydupras
Copy link
Contributor

Description

Lock information will be gathered through a separate API and correlated in a future job scheduler dashboard. This PR removes the locks qualities from the getScheduledJobInfo transport action and from tests.

The linked hash set was added to ensure the JSON always comes out in the same order.
Delay was added into the schedule data structure.

Related Issues

no issues

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Jeremy Dupras and others added 14 commits July 11, 2025 15:05
Signed-off-by: Jeremy Dupras <[email protected]>
Signed-off-by: Jeremy Dupras <[email protected]>
Signed-off-by: Jeremy Dupras <[email protected]>
Signed-off-by: Jeremy Dupras <[email protected]>
Signed-off-by: Jeremy Dupras <[email protected]>
Signed-off-by: Jeremy Dupras <[email protected]>
Signed-off-by: Jeremy Dupras <[email protected]>
Signed-off-by: Jeremy Dupras <[email protected]>
Signed-off-by: Jeremy Dupras <[email protected]>
Signed-off-by: Jeremy Dupras <[email protected]>
Signed-off-by: Jeremy Dupras <[email protected]>
Signed-off-by: Jeremy Dupras <[email protected]>
Copy link

codecov bot commented Jul 23, 2025

Codecov Report

Attention: Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.

Project coverage is 33.45%. Comparing base (638072c) to head (294a793).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...nsport/action/TransportGetScheduledInfoAction.java 0.00% 11 Missing ⚠️

❌ Your project status has failed because the head coverage (33.45%) is below the target coverage (75.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #801      +/-   ##
============================================
- Coverage     33.54%   33.45%   -0.10%     
  Complexity      143      143              
============================================
  Files            29       29              
  Lines          1389     1393       +4     
  Branches        132      133       +1     
============================================
  Hits            466      466              
- Misses          886      890       +4     
  Partials         37       37              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Jeremy Dupras <[email protected]>
@cwperks cwperks merged commit cf681a4 into opensearch-project:main Jul 23, 2025
13 of 15 checks passed
@github-project-automation github-project-automation bot moved this from 👀 In Review to ✅ Done in Engineering Effectiveness Board Jul 23, 2025
@cwperks cwperks changed the title Removing lock from the GetJobInfo Transport action and reformatting JSON response Move info about delay to the the schedule portion in List Jobs API Jul 23, 2025
Jeremydupras added a commit to Jeremydupras/job-scheduler that referenced this pull request Aug 20, 2025
…SON response (opensearch-project#801)

* adding active jobs by lock info

Signed-off-by: Jeremy Dupras <[email protected]>

* adding active jobs and tests

Signed-off-by: Jeremy Dupras <[email protected]>

* changing to ActionListener

Signed-off-by: Jeremy Dupras <[email protected]>

* fixing failing multinode test and format errors

Signed-off-by: Jeremy Dupras <[email protected]>

* correcting test

Signed-off-by: Jeremy Dupras <[email protected]>

* updating test

Signed-off-by: Jeremy Dupras <[email protected]>

* updating test

Signed-off-by: Jeremy Dupras <[email protected]>

* trying test fix

Signed-off-by: Jeremy Dupras <[email protected]>

* updating test

Signed-off-by: Jeremy Dupras <[email protected]>

* rerunning tests

Signed-off-by: Jeremy Dupras <[email protected]>

* removing getFirst()

Signed-off-by: Jeremy Dupras <[email protected]>

* removing lock search

Signed-off-by: Jeremy Dupras <[email protected]>

* remiving client

Signed-off-by: Jeremy Dupras <[email protected]>

* adding lock duration

Signed-off-by: Jeremy Dupras <[email protected]>

---------

Signed-off-by: Jeremy Dupras <[email protected]>
Co-authored-by: Jeremy Dupras <[email protected]>
Signed-off-by: Jeremy Dupras <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

2 participants