Skip to content

Conversation

cwperks
Copy link
Member

@cwperks cwperks commented Aug 12, 2025

Description

This PR contains 2 primary changes:

  • Updates the TransportGetScheduledInfoAction to re-use marshaling logic from other classes that it uses to produce the API response for list jobs API
  • Change ScheduledJobParameter from an interface to an extensible class

Note: The change to ScheduledJobParameter is breaking for plugins that extend the job scheduler, but it does provide benefits to remove code duplication. Many plugins that implement this interface copy the same boiler plate code and having a superclass with common methods would remove the boilerplate.

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…e methods for subclasses

Signed-off-by: Craig Perkins <[email protected]>
Copy link

codecov bot commented Aug 12, 2025

Codecov Report

❌ Patch coverage is 65.38462% with 36 lines in your changes missing coverage. Please review.
✅ Project coverage is 68.36%. Comparing base (a65cf07) to head (8a18004).

Files with missing lines Patch % Lines
...arch/jobscheduler/scheduler/JobSchedulingInfo.java 57.14% 15 Missing ⚠️
...bscheduler/sampleextension/SampleJobParameter.java 38.46% 8 Missing ⚠️
...r/transport/response/GetScheduledInfoResponse.java 81.48% 4 Missing and 1 partial ⚠️
...arch/jobscheduler/model/ExtensionJobParameter.java 42.85% 4 Missing ⚠️
...ler/transport/request/GetScheduledInfoRequest.java 33.33% 2 Missing ⚠️
...ensearch/jobscheduler/utils/JobDetailsService.java 0.00% 2 Missing ⚠️

❌ Your project check has failed because the head coverage (68.36%) is below the target coverage (75.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #813      +/-   ##
==========================================
- Coverage   69.80%   68.36%   -1.45%     
==========================================
  Files          38       36       -2     
  Lines        1729     1612     -117     
  Branches      156      132      -24     
==========================================
- Hits         1207     1102     -105     
- Misses        431      440       +9     
+ Partials       91       70      -21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

1 participant