Skip to content

Conversation

cwperks
Copy link
Member

@cwperks cwperks commented Aug 22, 2025

Description

Re-opening #822, but isolating the changes to just the newly introduced HistoryModel.

This PR removes manual tracking of seqNo and priTerm for the StatusHistoryModel. See details here about why they make sense on the LockModel. Since an entry in job history is recorded after successful acquisition of a Lock, we can be assured at that point in time that multiple nodes would not be trying to record simultaneously, only the node that successfully acquires a lock will. These fields serve no real purpose and can be safely removed.

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Craig Perkins <[email protected]>
Copy link

codecov bot commented Aug 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.87%. Comparing base (1a6dbf4) to head (4758d4f).
⚠️ Report is 2 commits behind head on main.

❌ Your project check has failed because the head coverage (69.87%) is below the target coverage (75.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #824   +/-   ##
=======================================
  Coverage   69.87%   69.87%           
=======================================
  Files          38       38           
  Lines        1733     1733           
  Branches      156      156           
=======================================
  Hits         1211     1211           
  Misses        431      431           
  Partials       91       91           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

1 participant