Skip to content

Conversation

nathaliellenaa
Copy link
Contributor

@nathaliellenaa nathaliellenaa commented Oct 10, 2025

Description

Enable execute tool feature flag by default + update 3.3 release note

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@nathaliellenaa nathaliellenaa requested a deployment to ml-commons-cicd-env-require-approval October 10, 2025 21:14 — with GitHub Actions Waiting
@nathaliellenaa nathaliellenaa requested a deployment to ml-commons-cicd-env-require-approval October 10, 2025 21:14 — with GitHub Actions Waiting
@nathaliellenaa nathaliellenaa requested a deployment to ml-commons-cicd-env-require-approval October 10, 2025 21:14 — with GitHub Actions Waiting
@nathaliellenaa nathaliellenaa requested a deployment to ml-commons-cicd-env-require-approval October 10, 2025 21:14 — with GitHub Actions Waiting
@nathaliellenaa nathaliellenaa requested a deployment to ml-commons-cicd-env-require-approval October 10, 2025 21:26 — with GitHub Actions Waiting
@nathaliellenaa nathaliellenaa requested a deployment to ml-commons-cicd-env-require-approval October 10, 2025 21:26 — with GitHub Actions Waiting
@nathaliellenaa nathaliellenaa requested a deployment to ml-commons-cicd-env-require-approval October 10, 2025 21:26 — with GitHub Actions Waiting
@nathaliellenaa nathaliellenaa requested a deployment to ml-commons-cicd-env-require-approval October 10, 2025 21:26 — with GitHub Actions Waiting
@nathaliellenaa nathaliellenaa changed the title Remove feature flag for execute tool API Enable execute tool feature flag by default Oct 10, 2025
@nathaliellenaa nathaliellenaa had a problem deploying to ml-commons-cicd-env-require-approval October 10, 2025 21:59 — with GitHub Actions Error
@nathaliellenaa nathaliellenaa had a problem deploying to ml-commons-cicd-env-require-approval October 10, 2025 21:59 — with GitHub Actions Error
@nathaliellenaa nathaliellenaa had a problem deploying to ml-commons-cicd-env-require-approval October 10, 2025 21:59 — with GitHub Actions Failure
@nathaliellenaa nathaliellenaa had a problem deploying to ml-commons-cicd-env-require-approval October 10, 2025 21:59 — with GitHub Actions Failure
pyek-bot
pyek-bot previously approved these changes Oct 10, 2025
Copy link
Collaborator

@pyek-bot pyek-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this require doc change as well?

@nathaliellenaa
Copy link
Contributor Author

Does this require doc change as well?

I missed adding doc for this feature during 3.2 release, created the doc PR opensearch-project/documentation-website#11214

@nathaliellenaa nathaliellenaa had a problem deploying to ml-commons-cicd-env-require-approval October 11, 2025 00:25 — with GitHub Actions Error
@nathaliellenaa nathaliellenaa had a problem deploying to ml-commons-cicd-env-require-approval October 11, 2025 00:25 — with GitHub Actions Failure
@nathaliellenaa nathaliellenaa temporarily deployed to ml-commons-cicd-env-require-approval October 11, 2025 00:25 — with GitHub Actions Inactive
@nathaliellenaa nathaliellenaa temporarily deployed to ml-commons-cicd-env-require-approval October 11, 2025 00:25 — with GitHub Actions Inactive
pyek-bot
pyek-bot previously approved these changes Oct 11, 2025
dhrubo-os
dhrubo-os previously approved these changes Oct 11, 2025
Signed-off-by: Nathalie Jonathan <[email protected]>
Signed-off-by: Nathalie Jonathan <[email protected]>
Signed-off-by: Nathalie Jonathan <[email protected]>
Signed-off-by: Nathalie Jonathan <[email protected]>
Signed-off-by: Nathalie Jonathan <[email protected]>
@nathaliellenaa
Copy link
Contributor Author

Local build passed before last rebase

@nathaliellenaa nathaliellenaa had a problem deploying to ml-commons-cicd-env-require-approval October 11, 2025 01:02 — with GitHub Actions Failure
@nathaliellenaa nathaliellenaa had a problem deploying to ml-commons-cicd-env-require-approval October 11, 2025 01:02 — with GitHub Actions Failure
@nathaliellenaa nathaliellenaa had a problem deploying to ml-commons-cicd-env-require-approval October 11, 2025 01:02 — with GitHub Actions Error
@nathaliellenaa nathaliellenaa had a problem deploying to ml-commons-cicd-env-require-approval October 11, 2025 01:02 — with GitHub Actions Error
@nathaliellenaa
Copy link
Contributor Author

Failing test due to throttling

RestMLRAGSearchProcessorIT > testBM25WithBedrockConverseUsingLlmMessages FAILED
    org.opensearch.client.ResponseException: method [POST], host [http://127.0.0.1:43855/], URI [/test/_search?size=5&search_pipeline=pipeline_test], status line [HTTP/1.1 429 Too Many Requests]
    {"error":{"root_cause":[{"type":"remote_connector_throttling_exception","reason":"Error from remote service: The request was denied due to remote server throttling. To change the retry policy and behavior, please update the connector client_config."}],"type":"remote_connector_throttling_exception","reason":"Error from remote service: The request was denied due to remote server throttling. To change the retry policy and behavior, please update the connector client_config."},"status":429}
        at __randomizedtesting.SeedInfo.seed([BF3399337A39DDAE:CD3872492123B0C0]:0)
        at app//org.opensearch.client.RestClient.convertResponse(RestClient.java:501)
        at app//org.opensearch.client.RestClient.performRequest(RestClient.java:384)
        at app//org.opensearch.client.RestClient.performRequest(RestClient.java:359)
        at app//org.opensearch.ml.utils.TestHelper.makeRequest(TestHelper.java:199)
        at app//org.opensearch.ml.utils.TestHelper.makeRequest(TestHelper.java:172)
        at app//org.opensearch.ml.rest.RestMLRAGSearchProcessorIT.performSearch(RestMLRAGSearchProcessorIT.java:1450)
        at app//org.opensearch.ml.rest.RestMLRAGSearchProcessorIT.testBM25WithBedrockConverseUsingLlmMessages(RestMLRAGSearchProcessorIT.java:892)

@dhrubo-os dhrubo-os merged commit 2d85f10 into opensearch-project:main Oct 11, 2025
6 of 10 checks passed
@dhrubo-os
Copy link
Collaborator

Approved and merged in favor of local build.

opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 11, 2025
* Change default settings to true

Signed-off-by: Nathalie Jonathan <[email protected]>

* update release note

Signed-off-by: Nathalie Jonathan <[email protected]>

* Fix failing test

Signed-off-by: Nathalie Jonathan <[email protected]>

* Update release note

Signed-off-by: Nathalie Jonathan <[email protected]>

* Update release note

Signed-off-by: Nathalie Jonathan <[email protected]>

---------

Signed-off-by: Nathalie Jonathan <[email protected]>
(cherry picked from commit 2d85f10)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants