Skip to content

Ignore flaky RestChatAgentWithMcpConnectorIT.testChatAgentWithMcpStreamableHttpConnector - #4943

Open
rithinpullela wants to merge 1 commit into
opensearch-project:mainfrom
rithinpullela:ignore/flaky-mcp-chat-agent-it
Open

Ignore flaky RestChatAgentWithMcpConnectorIT.testChatAgentWithMcpStreamableHttpConnector#4943
rithinpullela wants to merge 1 commit into
opensearch-project:mainfrom
rithinpullela:ignore/flaky-mcp-chat-agent-it

Conversation

@rithinpullela

Copy link
Copy Markdown
Collaborator

Ignores testChatAgentWithMcpStreamableHttpConnector, which fails intermittently on the multi-node CI leg. Root cause and a proper fix are being tracked separately.

…amableHttpConnector

Signed-off-by: rithinpullela <rithinp@amazon.com>
@github-actions

Copy link
Copy Markdown

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

🧪 No relevant tests
🔒 No security concerns identified
✅ No TODO sections
🔀 No multiple PR themes
⚡ No major issues detected

@github-actions

Copy link
Copy Markdown

PR Code Suggestions ✨

Explore these optional code suggestions:

CategorySuggestion                                                                                                                                    Impact
General
Ensure ignored test is actually skipped

The @Ignore annotation on JUnit test methods only takes effect when the method is
also annotated with @Test. Since this test method appears to rely on JUnit 3-style
naming conventions (method prefixed with test) inherited from the OpenSearch test
framework, @Ignore may not be respected and the test could still run. Add an
explicit @Test annotation or use an Assume.assumeTrue(false) / early return to
reliably skip the test.

plugin/src/test/java/org/opensearch/ml/rest/RestChatAgentWithMcpConnectorIT.java [139-140]

 @Ignore("Flaky on multi-node CI: MCP loopback tool call intermittently times out under load")
 public void testChatAgentWithMcpStreamableHttpConnector() throws IOException {
+    Assume.assumeTrue("Skipping flaky MCP streamable HTTP connector test", false);
Suggestion importance[1-10]: 7

__

Why: Valid concern: OpenSearch test framework extends JUnit 3-style OpenSearchTestCase, where @Ignore may not reliably skip tests without @Test. Adding Assume.assumeTrue(false) ensures the test is skipped, which is a meaningful correctness improvement for CI stability.

Medium

@rithinpullela
rithinpullela temporarily deployed to ml-commons-cicd-env July 29, 2026 03:52 — with GitHub Actions Inactive
@rithinpullela
rithinpullela temporarily deployed to ml-commons-cicd-env July 29, 2026 03:52 — with GitHub Actions Inactive
@rithinpullela
rithinpullela temporarily deployed to ml-commons-cicd-env July 29, 2026 03:52 — with GitHub Actions Inactive
@rithinpullela
rithinpullela temporarily deployed to ml-commons-cicd-env July 29, 2026 04:19 — with GitHub Actions Inactive
@rithinpullela
rithinpullela temporarily deployed to ml-commons-cicd-env July 29, 2026 04:19 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants