-
Notifications
You must be signed in to change notification settings - Fork 89
Support analyzer-based neural sparse query #1088
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support analyzer-based neural sparse query #1088
Conversation
d8b6544
to
fc2fb2d
Compare
Signed-off-by: zhichao-aws <[email protected]>
Signed-off-by: zhichao-aws <[email protected]>
Signed-off-by: zhichao-aws <[email protected]>
396505c
to
628ac6c
Compare
Signed-off-by: zhichao-aws <[email protected]>
Signed-off-by: zhichao-aws <[email protected]>
src/main/java/org/opensearch/neuralsearch/query/NeuralSparseQueryBuilder.java
Show resolved
Hide resolved
src/main/java/org/opensearch/neuralsearch/query/NeuralSparseQueryBuilder.java
Show resolved
Hide resolved
src/main/java/org/opensearch/neuralsearch/query/NeuralSparseQueryBuilder.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/neuralsearch/query/NeuralSparseQueryTwoPhaseInfo.java
Show resolved
Hide resolved
Signed-off-by: zhichao-aws <[email protected]>
Signed-off-by: zhichao-aws <[email protected]>
Signed-off-by: zhichao-aws <[email protected]>
Signed-off-by: zhichao-aws <[email protected]>
Signed-off-by: zhichao-aws <[email protected]>
src/main/java/org/opensearch/neuralsearch/query/NeuralSparseQueryBuilder.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/neuralsearch/query/NeuralSparseQueryBuilder.java
Show resolved
Hide resolved
src/main/java/org/opensearch/neuralsearch/query/NeuralSparseQueryBuilder.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/neuralsearch/query/NeuralSparseQueryBuilder.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/neuralsearch/query/NeuralSparseQueryBuilder.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/neuralsearch/query/NeuralSparseQueryBuilder.java
Outdated
Show resolved
Hide resolved
LGTM, will approve once some nit comments resolved. |
Signed-off-by: zhichao-aws <[email protected]>
Signed-off-by: zhichao-aws <[email protected]>
src/main/java/org/opensearch/neuralsearch/query/NeuralSparseQueryBuilder.java
Show resolved
Hide resolved
@zhichao-aws Must we merge this PR after: opensearch-project/ml-commons#3719? |
We can merge this first. All UTs and ITs are built using standard analyzer. I'll create a follow-up PR to add bert-based and mbert-based IT after the ml-commons PR merged. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1088 +/- ##
============================================
- Coverage 80.94% 0 -80.95%
============================================
Files 132 0 -132
Lines 5819 0 -5819
Branches 937 0 -937
============================================
- Hits 4710 0 -4710
+ Misses 751 0 -751
+ Partials 358 0 -358 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Description
Implementation for #1052
Check List
--signoff
.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.