Replace usages of ThreadContext.stashContext with PluginClient #1060
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR replaces usages of ThreadContext.stashContext with a replacement that enforces strong ownership over system indices. The reporting plugin can access the system indices it declares with SystemIndexPlugin.getSystemIndexDescriptors, but otherwise needs to declare additional perms like this: https://github.com/opensearch-project/geospatial/blob/main/src/main/resources/plugin-additional-permissions.yml
The replacement restricts what plugins can do inside a privileged context, but permits access to their own system indices.
Related Issues
Resolves opensearch-project/opensearch-plugins#238
Check List
--signoff
.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.