-
Notifications
You must be signed in to change notification settings - Fork 82
Remove start param to exclude task publishPluginZipPublicationToMavenLocal #1063
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…Local Signed-off-by: Craig Perkins <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there a reason to remove this?
@Hailong-am see the PR description. Publishing the plugin zip to maven local does not work so this PR fixes it. Is there another way to publish plugin zip to maven local? Why is this line present? |
Verified that the reason this was added no longer applies: #554
|
@Hailong-am some additional context around this change is that I wanted to test the alerting plugin with a change from 3.3 in core so I version bumped this repo, tried publishing zip to maven local and it didn't work. I spent a little time to figure out why and found this line so thought I'd submit a PR to fix it. We should be able to publish any plugin zip to maven local. |
Agree, I was under the impression that there is a reason to keep it and you have found it related #554. If that issue have been resolved, it should safe to remove it. |
Description
This change allows a developer to perform
./gradlew publishPluginZipPublicationToMavenLocal -Dbuild.snapshot=true -i
to publish a zip of the notifications repo to maven local.Resolves #1067
Check List
--signoff
.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.