Skip to content

Conversation

cwperks
Copy link
Member

@cwperks cwperks commented Aug 13, 2025

Description

This change allows a developer to perform ./gradlew publishPluginZipPublicationToMavenLocal -Dbuild.snapshot=true -i to publish a zip of the notifications repo to maven local.

Resolves #1067

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Collaborator

@Hailong-am Hailong-am left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a reason to remove this?

@cwperks
Copy link
Member Author

cwperks commented Aug 14, 2025

@Hailong-am see the PR description. Publishing the plugin zip to maven local does not work so this PR fixes it. Is there another way to publish plugin zip to maven local? Why is this line present?

@cwperks
Copy link
Member Author

cwperks commented Aug 14, 2025

Verified that the reason this was added no longer applies: #554

➜  notifications git:(publish-maven-local) ✗ ./gradlew :opensearch-notifications-core:publishNebulaPublicationToMavenLocal
Starting a Gradle Daemon, 1 incompatible Daemon could not be reused, use --status for details

> Configure project :notifications
Extracted latest 3.x version: 3.1.0
=======================================
OpenSearch Build Hamster says Hello!
  Gradle Version        : 8.14
  OS Info               : Mac OS X 15.6 (aarch64)
  JDK Version           : 21 (Eclipse Temurin JDK)
  JAVA_HOME             : /Users/cwperx/.sdkman/candidates/java/21.0.4-tem
  Random Testing Seed   : 726B1F72846F0A9
  Crypto Standard       : any-supported
=======================================

[Incubating] Problems report is available at: file:///Users/cwperx/Projects/opensearch/notifications/notifications/build/reports/problems/problems-report.html

Deprecated Gradle features were used in this build, making it incompatible with Gradle 9.0.

You can use '--warning-mode all' to show the individual deprecation warnings and determine if they come from your own scripts or plugins.

For more on this, please refer to https://docs.gradle.org/8.14/userguide/command_line_interface.html#sec:command_line_warnings in the Gradle documentation.

BUILD SUCCESSFUL in 10s

@cwperks
Copy link
Member Author

cwperks commented Aug 14, 2025

@Hailong-am some additional context around this change is that I wanted to test the alerting plugin with a change from 3.3 in core so I version bumped this repo, tried publishing zip to maven local and it didn't work. I spent a little time to figure out why and found this line so thought I'd submit a PR to fix it. We should be able to publish any plugin zip to maven local.

@Hailong-am
Copy link
Collaborator

@Hailong-am some additional context around this change is that I wanted to test the alerting plugin with a change from 3.3 in core so I version bumped this repo, tried publishing zip to maven local and it didn't work. I spent a little time to figure out why and found this line so thought I'd submit a PR to fix it. We should be able to publish any plugin zip to maven local.

Agree, I was under the impression that there is a reason to keep it and you have found it related #554. If that issue have been resolved, it should safe to remove it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] ./gradlew publishPluginZipPublicationToMavenLocal does not actually publish to maven local

2 participants