Skip to content

Adding search load for hybrid query with sort #565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

martin-gaievski
Copy link
Member

@martin-gaievski martin-gaievski commented Jan 13, 2025

Description

Adding procedure for existing workload for semantic search https://github.com/opensearch-project/opensearch-benchmark-workloads/tree/main/noaa_semantic_search that were added under #291.

New procedure is focused on performing hybrid and bool search queries when sort and search_after options are set.

This is needed for new sorting related features in hybrid query:

[Describe how this change was tested]
Stability of OSB tested with this PR: opensearch-project/opensearch-benchmark#727

Run following two commands.
First one creates index and ingests documents from NOAA dataset:

opensearch-benchmark execute-test --workload-path="/home/user/dev/opensearch/opensearch-benchmark-workloads/noaa_semantic_search/" --workload-params="/home/user/dev/opensearch/opensearch-benchmark-workloads/noaa_semantic_search/params/one_replica_no_concurrent_segment_search.json" --pipeline=benchmark-only --client-options=timeout:30 --target-host=localhost:9200 --kill-running-processes --test-procedure="create-and-index"

second command executes the new test procedure with all new search queries:

opensearch-benchmark execute-test --workload-path="/home/user/dev/opensearch/opensearch-benchmark-workloads-second/noaa_semantic_search/" --workload-params="/home/user/dev/opensearch/opensearch-benchmark-workloads/noaa_semantic_search/params/one_replica_no_concurrent_segment_search.json" --pipeline=benchmark-only --client-options=timeout:30 --target-host=localhost:9200 --kill-running-processes --test-procedure="hybrid-search-sorting"

Backport to Branches:

  • 6
  • 7
  • 1
  • 2
  • 3

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Collaborator

@IanHoang IanHoang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add these new queries and test procedures to the README?

@martin-gaievski martin-gaievski force-pushed the added-search-queries-with-sort-noaa-hybrid-query branch from 5c67090 to e7e97f5 Compare February 21, 2025 19:34
@martin-gaievski
Copy link
Member Author

Can you add these new queries and test procedures to the README?

@IanHoang Updated README with new procedure and also rebased on latest main branch.

@martin-gaievski
Copy link
Member Author

@IanHoang I've addressed your comments, do you have more requests or this can be merged?

@IanHoang IanHoang added backport 2 Backport to the "2" branch backport 1 backport 3 Backport to the "3" branch backport 7 Backport to the "7" branch backport 6 Backport to the "6" branch and removed backport 7 Backport to the "7" branch backport 6 Backport to the "6" branch labels Mar 18, 2025
@IanHoang
Copy link
Collaborator

IanHoang commented Mar 18, 2025

@martin-gaievski Looks good to me. Only backporting to branches 2 and 3 since those are the only branches that have noaa_semantic_search.

@IanHoang IanHoang merged commit 6e96e23 into opensearch-project:main Mar 18, 2025
7 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 18, 2025
* Adding search load for hybrid query with sort

Signed-off-by: Martin Gaievski <[email protected]>

* Update readme and rebased on latest main

Signed-off-by: Martin Gaievski <[email protected]>

---------

Signed-off-by: Martin Gaievski <[email protected]>
(cherry picked from commit 6e96e23)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 18, 2025
* Adding search load for hybrid query with sort

Signed-off-by: Martin Gaievski <[email protected]>

* Update readme and rebased on latest main

Signed-off-by: Martin Gaievski <[email protected]>

---------

Signed-off-by: Martin Gaievski <[email protected]>
(cherry picked from commit 6e96e23)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
OVI3D0 pushed a commit that referenced this pull request Mar 25, 2025
* Adding search load for hybrid query with sort



* Update readme and rebased on latest main



---------


(cherry picked from commit 6e96e23)

Signed-off-by: Martin Gaievski <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
OVI3D0 pushed a commit that referenced this pull request Mar 25, 2025
* Adding search load for hybrid query with sort



* Update readme and rebased on latest main



---------


(cherry picked from commit 6e96e23)

Signed-off-by: Martin Gaievski <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2 Backport to the "2" branch backport 3 Backport to the "3" branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants