-
Notifications
You must be signed in to change notification settings - Fork 115
only append success message if file format is not CSV #1003
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Michael Oviedo <[email protected]>
📝 WalkthroughWalkthroughThe benchmark finalization now writes the summary message to the results file only when a Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
📜 Recent review detailsConfiguration used: defaults Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In @osbenchmark/benchmark.py:
- Around line 1368-1373: The code assumes args.results_format exists when
checking args.results_format != "csv", which raises AttributeError for the
aggregate subcommand that only defines --results-file; change the condition to
guard access (e.g., use getattr(args, "results_format", None) != "csv" or check
hasattr(args, "results_format") before comparing) so the block that appends
message to args.results_file only runs when results_file is set and
results_format is either absent or not "csv"; update the conditional around
args, results_file, and results_format accordingly.
📜 Review details
Configuration used: defaults
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
osbenchmark/benchmark.py
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)
- GitHub Check: Unit-Tests (macos-latest)
- GitHub Check: Unit-Tests (ubuntu-latest)
- GitHub Check: docker (linux/amd64)
- GitHub Check: docker (linux/arm64)
- GitHub Check: Integration-Tests (3.12)
- GitHub Check: Integration-Tests (3.11)
- GitHub Check: Integration-Tests (3.10)
- GitHub Check: Integration-Tests (3.13)
Signed-off-by: Michael Oviedo <[email protected]>
Description
appending success messages to CSV files breaks the format of the file. This change only appends the message if the file format is not CSV
Issues Resolved
#1001
Testing
[Describe how this change was tested]
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.