Skip to content

Add load-test-qps parameter for dynamic client ramp up #739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 25, 2025

Conversation

OVI3D0
Copy link
Member

@OVI3D0 OVI3D0 commented Jan 30, 2025

Description

Adds a new --load-test-qps parameter for OSB. This parameter, when used with an appropriate test procedure such as:

{
  "name": "timed-mode-test-procedure",
  "schedule": [
    {
       "operation": "range",
       "warmup-time-period": {{ warmup_time | default(300) | tojson }},
       "ramp-up-time-period": {{ ramp_up_time | default(100) | tojson }},
       "time-period": {{ time_period | default(300) | tojson }},
       "target-throughput": {{ target_throughput | default(20) | tojson }},
       "clients": {{ search_clients | default(20) }}
    }
  ]
}

Overrides the target-throughput and client parameters, setting them to the integer value passed in by the user.
OSB then uses the ramp-up property introduced in #725 to ramp up the number of clients over time until the target QPS is hit.

Example command:
opensearch-benchmark execute-test --pipeline=benchmark-only --target-hosts=<cluster address> --workload=big5 --test-procedure=timed-mode-test-procedure --kill-running-processes --load-test-qps=30 --telemetry=node-states --telemetry-params="node-stats-include-indices-metrics:'search'"

Screenshot 2025-01-29 at 5 02 04 PM

Issues Resolved

#736

Testing

  • New functionality includes testing

make it + make test


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@OVI3D0 OVI3D0 force-pushed the dynamic-ramp-up branch 4 times, most recently from 0d9a2dd to cf76083 Compare January 30, 2025 01:23
@OVI3D0 OVI3D0 marked this pull request as ready for review January 30, 2025 01:39
@rishabh6788
Copy link
Collaborator

Looks good, can you also add a unit test for the same?

@OVI3D0 OVI3D0 force-pushed the dynamic-ramp-up branch 2 times, most recently from e7b61b3 to 192a727 Compare February 24, 2025 19:18
@OVI3D0 OVI3D0 merged commit 97ced94 into opensearch-project:main Feb 25, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants