Add load-test-qps parameter for dynamic client ramp up#739
Merged
OVI3D0 merged 3 commits intoopensearch-project:mainfrom Feb 25, 2025
Merged
Add load-test-qps parameter for dynamic client ramp up#739OVI3D0 merged 3 commits intoopensearch-project:mainfrom
load-test-qps parameter for dynamic client ramp up#739OVI3D0 merged 3 commits intoopensearch-project:mainfrom
Conversation
0d9a2dd to
cf76083
Compare
cf76083 to
f50ece2
Compare
Collaborator
|
Looks good, can you also add a unit test for the same? |
fd378e1 to
51ea2f9
Compare
Signed-off-by: Michael Oviedo <mikeovi@amazon.com>
Signed-off-by: Michael Oviedo <mikeovi@amazon.com>
e7b61b3 to
192a727
Compare
Signed-off-by: Michael Oviedo <mikeovi@amazon.com>
192a727 to
5fb2ea3
Compare
rishabh6788
approved these changes
Feb 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a new
--load-test-qpsparameter for OSB. This parameter, when used with an appropriate test procedure such as:Overrides the target-throughput and client parameters, setting them to the integer value passed in by the user.
OSB then uses the ramp-up property introduced in #725 to ramp up the number of clients over time until the target QPS is hit.
Example command:
opensearch-benchmark execute-test --pipeline=benchmark-only --target-hosts=<cluster address> --workload=big5 --test-procedure=timed-mode-test-procedure --kill-running-processes --load-test-qps=30 --telemetry=node-states --telemetry-params="node-stats-include-indices-metrics:'search'"Issues Resolved
#736
Testing
make it+make testBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.