Add distribution version in workload parameters #752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bowenlan-amzn
force-pushed
the
distribution_version
branch
from
a201912 to
0cc6946
Compare
|
@bowenlan-amzn Can you rebase the latest main changes onto this branch? This should address the ARM build |
Enhance workload configuration by automatically adding the cluster distribution version to workload parameters if not explicitly provided. This ensures that the distribution version is always available for workload json. Signed-off-by: bowenlan-amzn <[email protected]>
bowenlan-amzn
force-pushed
the
distribution_version
branch
from
0cc6946 to
d5f3a2a
Compare
bowenlan-amzn
requested review from
IanHoang,
gkamat,
beaioun,
rishabh6788,
VijayanB and
OVI3D0
as code owners
6 tasks
gkamat
requested changes
Mar 15, 2025
| @@ -115,3 +115,5 @@ recipes/ccr/ccr-target-hosts.json | |||
|
|
|||
| # Tracker tracks | |||
| tracks/ | |||
There was a problem hiding this comment.
Nit: "Tracks" can be removed, and a comment can be added for the Visual Studio suffix like with the other entries.
Comment on lines
+194
to
+197
| workload_params = self.cfg.opts("workload", "params", mandatory=False) | ||
| if "distribution_version" not in workload_params: # if not provided by user, we add the one we just got | ||
| workload_params["distribution_version"] = distribution_version | ||
| self.cfg.add(config.Scope.applicationOverride, "workload", "params", workload_params) |
There was a problem hiding this comment.
Please add tests for this feature, perhaps a couple of unit tests. Thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enhance workload configuration by automatically adding the cluster distribution version to workload parameters if not explicitly provided. This ensures that the distribution version is always available for workload json.
Apart from adding it, I have to exclude it from the check, some history from here
elastic/rally#478
Issues Resolved
opensearch-project/opensearch-benchmark-workloads#574
Testing
[Describe how this change was tested]
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.