Add warning when benchmarking multiple target hosts #779
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a warning when benchmarking multiple target hosts. Because OSB considers node count when checking for cluster health, two single-node clusters passed in via comma separated strings in the
--target-hosts
flag will result in an unhealthy status, and the benchmark will hang. However, as @IanHoang pointed out, passing in the two clusters via a JSON file will allow this check to pass.Here is an example of the warning:
Issues Resolved
#730
Testing
make test
+make it
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.