Skip to content

Conversation

@rishabh6788
Copy link
Collaborator

Description

This PR fixes the bug where the logic that needs cdk deploy to happen for opensource OS were running inside the sigv4 AWS credentials scope, required for AOS and AOSS. This was causing cdk deploy failures as permissions were getting overridden in the scope.

Issues Resolved

List any issues this PR will resolve, e.g. Closes [...].

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Rishabh Singh <[email protected]>
@codecov
Copy link

codecov bot commented Nov 26, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.55%. Comparing base (d092678) to head (ced0a1b).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #798   +/-   ##
=========================================
  Coverage     89.55%   89.55%           
  Complexity      129      129           
=========================================
  Files           121      121           
  Lines           680      680           
  Branches         44       44           
=========================================
  Hits            609      609           
  Misses           36       36           
  Partials         35       35           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@peterzhuamazon
Copy link
Member

Hi @rishabh6788 can you bump the version as well?

Thanks.

@rishabh6788
Copy link
Collaborator Author

Hi @rishabh6788 can you bump the version as well?

Thanks.

It was bumped in #796, I will run the increment version job again and get it bumped.

@rishabh6788 rishabh6788 merged commit 2dc5f4f into opensearch-project:main Nov 26, 2025
10 checks passed
@github-project-automation github-project-automation bot moved this from 👀 In Review to ✅ Done in Engineering Effectiveness Board Nov 26, 2025
@opensearch-trigger-bot
Copy link

The backport to 11.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-11.x 11.x
# Navigate to the new working tree
pushd ../.worktrees/backport-11.x
# Create a new branch
git switch --create backport/backport-798-to-11.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 2dc5f4f3f66937c9af213275ede59330a3aee3bf
# Push it to GitHub
git push --set-upstream origin backport/backport-798-to-11.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-11.x

Then, create a pull request where the base branch is 11.x and the compare/head branch is backport/backport-798-to-11.x.

opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 26, 2025
Signed-off-by: Rishabh Singh <[email protected]>
(cherry picked from commit 2dc5f4f)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

2 participants