-
Notifications
You must be signed in to change notification settings - Fork 28
refactor sigv4 logic #798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor sigv4 logic #798
Conversation
Signed-off-by: Rishabh Singh <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #798 +/- ##
=========================================
Coverage 89.55% 89.55%
Complexity 129 129
=========================================
Files 121 121
Lines 680 680
Branches 44 44
=========================================
Hits 609 609
Misses 36 36
Partials 35 35 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hi @rishabh6788 can you bump the version as well? Thanks. |
It was bumped in #796, I will run the increment version job again and get it bumped. |
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-11.x 11.x
# Navigate to the new working tree
pushd ../.worktrees/backport-11.x
# Create a new branch
git switch --create backport/backport-798-to-11.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 2dc5f4f3f66937c9af213275ede59330a3aee3bf
# Push it to GitHub
git push --set-upstream origin backport/backport-798-to-11.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-11.xThen, create a pull request where the |
Signed-off-by: Rishabh Singh <[email protected]> (cherry picked from commit 2dc5f4f) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Description
This PR fixes the bug where the logic that needs cdk deploy to happen for opensource OS were running inside the sigv4 AWS credentials scope, required for AOS and AOSS. This was causing cdk deploy failures as permissions were getting overridden in the scope.
Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.