Make OPENSEARCH_DASHBOARDS_HOME args works correctly in dashboards dockerfile #4327
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donggyu04
requested review from
Divyaasm,
bbarani,
dblock,
gaiksaya,
jordarlu,
peterzhuamazon,
prudhvigodithi,
rishabh6788,
tianleh and
zelinh
as code owners
donggyu04
commented
Jan 5, 2024
| longopts=() | ||
| for opensearch_dashboards_var in ${opensearch_dashboards_vars[*]}; do | ||
| # 'opensearch.hosts' -> 'OPENSEARCH_URL' | ||
| # 'opensearch.hosts' -> 'OPENSEARCH_HOSTS' |
There was a problem hiding this comment.
opensearch.hosts is converted to OPENSEARCH_HOSTS. OPENSEARCH_URL is not correct.
donggyu04
commented
Jan 5, 2024
| # --opensearch.startupTimeout=60 | ||
|
|
||
| # Setup Home Directory | ||
| export OPENSEARCH_DASHBOARDS_HOME=/usr/share/opensearch-dashboards |
There was a problem hiding this comment.
I think this depends on ARG OPENSEARCH_DASHBOARDS_HOME in Dockerfile. so I added this to ENV at Dockerfile
…ckerfile Signed-off-by: leedonggyu <[email protected]>
donggyu04
force-pushed
the
make-dashboards-home-works-correctly-in-dockerfile
branch
from
619f0a0 to
5d75316
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
OPENSEARCH_DASHBOARDS_HOMEargument works correctly.