Skip to content

Conversation

peterzhuamazon
Copy link
Member

@peterzhuamazon peterzhuamazon commented May 3, 2025

Description

Temp resolve path.repo not found issues on k-NN

Will move the script to k-NN repo once 3.0.0 is released to public to avoid building new RCs.

2> REPRODUCE WITH: gradlew ':integTest' --tests "org.opensearch.knn.integ.DerivedSourceIT.testDerivedSource_whenSegrepLocal_thenDisabled" -Dtests.seed=3D5D0C854DD4AA88 -Dtests.security.manager=false -Dtests.locale=dua-Latn-CM -Dtests.timezone=Asia/Novokuznetsk -Druntime.java=21

  2> org.opensearch.client.ResponseException: method [PUT], host [http://localhost:9200/], URI [_snapshot/repo?verify=true], status line [HTTP/1.1 500 Internal Server Error]

    {"error":{"root_cause":[{"type":"repository_exception","reason":"[repo] location [C:\\5iv84bze\\k-NN\\build/testSnapshotFolder] doesn't match any of the locations specified by path.repo"}],"type":"repository_exception","reason":"[repo] failed to create repository","caused_by":{"type":"repository_exception","reason":"[repo] location [C:\\5iv84bze\\k-NN\\build/testSnapshotFolder] doesn't match any of the locations specified by path.repo"}},"status":500}

        at __randomizedtesting.SeedInfo.seed([3D5D0C854DD4AA88:95AB786E87274F6D]:0)

        at app//org.opensearch.client.RestClient.convertResponse(RestClient.java:501)

        at app//org.opensearch.client.RestClient.performRequest(RestClient.java:384)

        at app//org.opensearch.client.RestClient.performRequest(RestClient.java:359)

        at app//org.opensearch.test.rest.OpenSearchRestTestCase.registerRepository(OpenSearchRestTestCase.java:1097)

        at app//org.opensearch.knn.integ.DerivedSourceIT.setUp(DerivedSourceIT.java:42)

  2> REPRODUCE WITH: gradlew ':integTest' --tests "org.opensearch.knn.integ.DerivedSourceIT.testNes

Reason being k-NN is hardcoding the tests.path.repo to https://github.com/opensearch-project/k-NN/blob/3.0/build.gradle#L443, and the folder is not available in opensearch.yml during test.

Therefore, override it when running integTest on Jenkins.

Issues Resolved

#3747

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@peterzhuamazon peterzhuamazon marked this pull request as draft May 3, 2025 23:37
@peterzhuamazon
Copy link
Member Author

peterzhuamazon commented May 4, 2025

Sample run:

2025-05-04 03:32:24 INFO     | k-NN                 | with-security        | PASS  |
2025-05-04 03:32:24 INFO     | k-NN                 | without-security     | PASS  |
2025-05-04 05:29:15 INFO     | k-NN                 | with-security        | PASS  |
2025-05-04 05:29:15 INFO     | k-NN                 | without-security     | PASS  |

@peterzhuamazon peterzhuamazon marked this pull request as ready for review May 4, 2025 04:29
@peterzhuamazon peterzhuamazon merged commit b36dea9 into opensearch-project:main May 4, 2025
13 checks passed
@peterzhuamazon peterzhuamazon deleted the temp-knn-windowsfix branch May 4, 2025 04:29
@github-project-automation github-project-automation bot moved this from 👀 In Review to ✅ Done in Engineering Effectiveness Board May 4, 2025
Copy link

codecov bot commented May 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (e1e207d) to head (198a7d1).
Report is 1 commits behind head on main.

❌ Your project status has failed because the head coverage (0.00%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@     Coverage Diff      @@
##   main   #5505   +/-   ##
============================
============================

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@peterzhuamazon peterzhuamazon mentioned this pull request May 4, 2025
66 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

3 participants