Skip to content

Conversation

weijia-aws
Copy link
Contributor

Description

This PR add changes to onboard smoke test for geospatial plugin

Issues Resolved

724

Test

./test.sh smoke-test manifests/2.19.3/opensearch-2.19.3-test.yml --component geospatial --paths opensearch=https://ci.opensearch.org/ci/dbc/distribution-build-opensearch/2.19.3/11066/linux/x64/tar


2025-05-16 13:04:54 INFO     | geospatial           | /_plugins/geospatial/_upload/stats GET | PASS  |
2025-05-16 13:04:54 INFO     | geospatial           | /_plugins/geospatial/geojson/_upload PUT | PASS  |
2025-05-16 13:04:54 INFO     | geospatial           | /_plugins/geospatial/ip2geo/datasource GET | PASS  |
2025-05-16 13:04:54 INFO     | geospatial           | /_plugins/geospatial/ip2geo/datasource/test-datasource GET | PASS  |
2025-05-16 13:04:54 INFO     | geospatial           | /_plugins/geospatial/ip2geo/datasource/test-datasource PUT | PASS  |


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Member

@zelinh zelinh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @weijia-aws Thanks for your PR. I don't think you need to add smoke tests to published release version like 2.18-2.19.2 and 3.0.0. You only need to add it to 2.19.3 and 3.1.0 which are not released yet.

@weijia-aws weijia-aws marked this pull request as draft May 16, 2025 23:00
@weijia-aws weijia-aws force-pushed the geospatial-smoke-test branch from 0383620 to 4372d7e Compare May 16, 2025 23:05
@weijia-aws weijia-aws marked this pull request as ready for review May 16, 2025 23:12
@zelinh
Copy link
Member

zelinh commented May 19, 2025

The groovy CI tests pending is not related to this PR. We are looking into that.

@zelinh
Copy link
Member

zelinh commented May 20, 2025

@weijia-aws Could you rebase from main branch? We should have fixed the CI failures.

@weijia-aws
Copy link
Contributor Author

Will do

@weijia-aws weijia-aws force-pushed the geospatial-smoke-test branch from 4372d7e to 35258cf Compare May 21, 2025 18:54
@zelinh zelinh merged commit fbe7959 into opensearch-project:main May 21, 2025
16 checks passed
@github-project-automation github-project-automation bot moved this from 👀 In Review to ✅ Done in Engineering Effectiveness Board May 21, 2025
Copy link

codecov bot commented May 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (b104d3c) to head (35258cf).
Report is 2 commits behind head on main.

❌ Your project status has failed because the head coverage (0.00%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@     Coverage Diff      @@
##   main   #5521   +/-   ##
============================
============================

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

2 participants