Skip to content

Conversation

peterzhuamazon
Copy link
Member

Description

Move 1.x manifests to legacy and add search-relevance to version increments

Issues Resolved

List any issues this PR will resolve, e.g. Closes [...].

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@gaiksaya
Copy link
Member

@peterzhuamazon
Copy link
Member Author

Do we need to make any changes to metrics for these versions? https://github.com/opensearch-project/opensearch-metrics/blob/main/src/main/java/org/opensearchmetrics/metrics/release/ReleaseInputs.java#L24-L29 @prudhvigodithi

I think since they are closed we good?

@peterzhuamazon
Copy link
Member Author

Hi @prudhvigodithi are we ready to merge this?

Thanks.

@prudhvigodithi
Copy link
Member

Hey @peterzhuamazon I have created a PR from metrics opensearch-project/opensearch-metrics#135 to exclude 1.3.

@peterzhuamazon
Copy link
Member Author

peterzhuamazon commented Jun 3, 2025

Should be ready to merge as pre-requisite is merged:

Thanks.

@peterzhuamazon peterzhuamazon merged commit 30ff4ad into opensearch-project:main Jun 3, 2025
15 checks passed
@github-project-automation github-project-automation bot moved this from 👀 In Review to ✅ Done in Engineering Effectiveness Board Jun 3, 2025
@peterzhuamazon peterzhuamazon deleted the deprecate-1.x branch June 3, 2025 20:37
Copy link

codecov bot commented Jun 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (8e24e0e) to head (ee054f7).
Report is 5 commits behind head on main.

❌ Your project status has failed because the head coverage (0.00%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@     Coverage Diff      @@
##   main   #5534   +/-   ##
============================
============================

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

5 participants