Onboarding search-relevance on smoke testing #5572
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Martin Gaievski <[email protected]>
martin-gaievski
force-pushed
the
onboard_search_relevance_on_smoke_testing
branch
from
30c7c91 to
e868477
Compare
|
tried to test spec against latest 3.1.0 build, got following errors. Looks like some specifications are not correct: |
martin-gaievski
force-pushed
the
onboard_search_relevance_on_smoke_testing
branch
from
e1a2dac to
56a5882
Compare
Signed-off-by: Martin Gaievski <[email protected]>
martin-gaievski
force-pushed
the
onboard_search_relevance_on_smoke_testing
branch
from
56a5882 to
932fb1b
Compare
martin-gaievski
requested review from
Divyaasm,
gaiksaya,
peterzhuamazon,
prudhvigodithi,
rishabh6788,
tianleh and
zelinh
as code owners
zelinh
reviewed
Jun 12, 2025
PR from @ajleong623 for spec updates is still open, but looks like we're getting responses from all APIs even without that PR. |
Yeah the responses come from the plugin itself while this smoke tests framework relies on the API spec as source of truth to validate. Even the responses were expected but not fully align with api spec, this smoke tests validation would fail. |
|
@zelinh would the changes in the api specification affect the manifests CI check? I have been working on understanding how the changes in the api spec actually affect the smoke tests. The only other changes I made were creating the dockerfile/docker-compose.yml in the plugin test and adding to the workflow (https://github.com/opensearch-project/opensearch-api-specification/blob/main/.github/workflows/test-spec.yml). I am not sure if those other changes actually affect the build tool or the verification. |
No it shouldn't affect the manifest CI check in this PR. I took a quick look and seems like the env setup for the manifest CI check failed. Just triggered re-run and now it's good. The smoke tests relies on api-spec and it's not checked on this CI level; it would failed when it's not validated with api-spec when triggering such workflow for example |
|
@zelinh Got it. So the solution would be to push the updated specification to the repository? |
Yes. All changes should be made to api-spec repo. You only provide API path and any parameters here in opensearch-build repo. |
|
@zelinh just to confirm, the GitHub workflow folder in the api spec repository and the docker compose in the test folder of the api spec repository are not being used in the verification process? It’s only the spec/namespace folder? I looked at the code, and it looks like the test runner only compares with a static file of the specification. |
Workflow or CI tests in api-spec repo has nothing to do with the smoke test framework here. Smoke test will only consume |
|
Seems like we have everything updated. |
|
@zelinh I believe the api specs work now. I did run it on my end. |
zelinh
approved these changes
Jun 18, 2025
There was a problem hiding this comment.
2025-06-17 14:35:47 INFO | search-relevance | /_cluster/settings PUT | PASS |
2025-06-17 14:35:47 INFO | search-relevance | /_plugins/_search_relevance/judgments PUT | PASS |
2025-06-17 14:35:47 INFO | search-relevance | /_plugins/_search_relevance/query_sets PUT | PASS |
2025-06-17 14:35:47 INFO | search-relevance | /_plugins/_search_relevance/search_configurations PUT | PASS |
2025-06-17 14:35:47 INFO | search-relevance | /_plugins/_search_relevance/stats GET | PASS |
LGTM! Thanks!
github-project-automation
bot
moved this to 👀 In Review
in Engineering Effectiveness Board
github-project-automation
bot
moved this from 👀 In Review
to ✅ Done
in Engineering Effectiveness Board
|
@zelinh will this change be reflected in test runs for 3.1 version or only in future releases? |
We have a cron job that triggered by our build job for running these tests. https://build.ci.opensearch.org/job/smoke-test/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enable smoke tests for search-relevance plugin
Issues Resolved
N/A
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.