-
Notifications
You must be signed in to change notification settings - Fork 312
Move old jenkins to legacy and ignore tests #5607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Sayali Gaikawad <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this legacy as well now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes! Actual file in use https://github.com/opensearch-project/data-prepper/blob/main/jenkins/release.jenkinsFile
import static com.lesfurets.jenkins.unit.global.lib.GitSource.gitSource | ||
|
||
class TestCCRPerfTest extends BuildPipelineTest { | ||
@Ignore class TestCCRPerfTest extends BuildPipelineTest { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why ignore instead of remove here?
Unless you are thinking about potential re-use them later?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a push back last time when I tried removing. Let me know what you prefer. I am okay with removing them as well.
Codecov ReportAll modified and coverable lines are covered by tests ✅
❌ Your project status has failed because the head coverage (0.00%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #5607 +/- ##
==========================================
- Coverage 92.01% 0 -92.02%
==========================================
Files 202 0 -202
Lines 7078 0 -7078
==========================================
- Hits 6513 0 -6513
+ Misses 565 0 -565 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
I have updated the jenkinsfile file location for https://build.ci.opensearch.org/job/publish-to-maven/ workflow. |
Signed-off-by: Sayali Gaikawad <[email protected]>
Description
Move old jenkins to legacy and ignore tests associated with those jenkins files.
Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.