Replace secrets with onepassword in packer-build jenkinsfile #5608
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Zhu <[email protected]>
Signed-off-by: Peter Zhu <[email protected]>
peterzhuamazon
requested review from
Divyaasm,
prudhvigodithi and
zelinh
as code owners
github-project-automation
bot
moved this to Backlog
in OpenSearch Engineering Effectiveness
peterzhuamazon
moved this from Backlog
to In review
in OpenSearch Engineering Effectiveness
gaiksaya
reviewed
Jun 25, 2025
| packer-build.withCredentials([AWS_ACCOUNT_PUBLIC], groovy.lang.Closure) | ||
| packer-build.withAWS({role=opensearch-packer, roleAccount=AWS_ACCOUNT_PUBLIC, duration=3600, roleSessionName=jenkins-session, useNode=true}, groovy.lang.Closure) | ||
| packer-build.withSecrets({secrets=[{envVar=vpc_id, secretRef=op://opensearch-infra-secrets/packer-build-ids/jenkins-agent-vpc-id}, {envVar=subnet_id, secretRef=op://opensearch-infra-secrets/packer-build-ids/jenkins-agent-subnet-id}, {envVar=sg_id, secretRef=op://opensearch-infra-secrets/packer-build-ids/jenkins-agent-sg-id}]}, groovy.lang.Closure) | ||
| packer-build.writeJSON({file=./packer/substitute_jenkins-agent-al2-arm64.json, json={variables={name-base=Jenkins-Agent-AL2-X64, os-version=AL2, build-region=us-east-1, build-vpc=vpc_id_123, build-subnet=subnet_id_123, build-secgrp=sg_id_123, build-time={{isotime "2006-01-02T03-04-05Z"}}, aws_ami_region=us-east-1}}, pretty=2}) |
There was a problem hiding this comment.
Will the secrets value be shown in the logging or this is just testing bug?
There was a problem hiding this comment.
I think onepassword will mask these secret env variables; secretRef will be visible to everyone as it's directing to the specific credential.
There was a problem hiding this comment.
There is no secret showing here?
It is just the name of the secret not the secret values.
zelinh
approved these changes
Jun 25, 2025
| packer-build.withCredentials([AWS_ACCOUNT_PUBLIC], groovy.lang.Closure) | ||
| packer-build.withAWS({role=opensearch-packer, roleAccount=AWS_ACCOUNT_PUBLIC, duration=3600, roleSessionName=jenkins-session, useNode=true}, groovy.lang.Closure) | ||
| packer-build.withSecrets({secrets=[{envVar=vpc_id, secretRef=op://opensearch-infra-secrets/packer-build-ids/jenkins-agent-vpc-id}, {envVar=subnet_id, secretRef=op://opensearch-infra-secrets/packer-build-ids/jenkins-agent-subnet-id}, {envVar=sg_id, secretRef=op://opensearch-infra-secrets/packer-build-ids/jenkins-agent-sg-id}]}, groovy.lang.Closure) | ||
| packer-build.writeJSON({file=./packer/substitute_jenkins-agent-al2-arm64.json, json={variables={name-base=Jenkins-Agent-AL2-X64, os-version=AL2, build-region=us-east-1, build-vpc=vpc_id_123, build-subnet=subnet_id_123, build-secgrp=sg_id_123, build-time={{isotime "2006-01-02T03-04-05Z"}}, aws_ami_region=us-east-1}}, pretty=2}) |
There was a problem hiding this comment.
I think onepassword will mask these secret env variables; secretRef will be visible to everyone as it's directing to the specific credential.
gaiksaya
approved these changes
Jun 26, 2025
github-project-automation
bot
moved this from In review
to Done
in OpenSearch Engineering Effectiveness
github-project-automation
bot
moved this from 👀 In Review
to ✅ Done
in Engineering Effectiveness Board
Codecov ReportAll modified and coverable lines are covered by tests ✅
❌ Your project status has failed because the head coverage (0.00%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #5608 +/- ##
============================
============================
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rishabh6788
pushed a commit
that referenced
this pull request
Jul 22, 2025
Signed-off-by: Peter Zhu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replace secrets with onepassword in packer-build jenkinsfile
Issues Resolved
#5535
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.