Add native plugin validation for staged artifacts #5610
Conversation
Divyaasm
requested review from
gaiksaya,
peterzhuamazon,
prudhvigodithi,
rishabh6788,
tianleh and
zelinh
as code owners
Divyaasm
force-pushed
the
stage
branch
5 times, most recently
from
a102c8d to
a829393
Compare
Signed-off-by: Divya Madala <[email protected]>
| try: | ||
| for native_plugin in native_plugins_list: | ||
| execute('.' + os.sep + f'opensearch-plugin install --batch {native_plugin}', os.path.join(path, "bin")) | ||
|
|
There was a problem hiding this comment.
Feels like you should just include this in download_and_install_native_plugin_zip func.
The func should internally check if it is staging vs production via a parameter.
There was a problem hiding this comment.
Then instead of moving just this block I can combine download_and_install_native_plugin_zip and install_native_plugin into one. Let me know.
Signed-off-by: Divya Madala <[email protected]>
github-project-automation
bot
moved this to 👀 In Review
in Engineering Effectiveness Board
github-project-automation
bot
moved this from 👀 In Review
to ✅ Done
in Engineering Effectiveness Board
Codecov ReportAll modified and coverable lines are covered by tests ✅
❌ Your project status has failed because the head coverage (0.00%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #5610 +/- ##
============================
============================
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Divya Madala <[email protected]>
2 participants
Description
Add native plugin validation for staged artifacts of distribution type tarball, rpm, debian, zip. And enables native plugin validation by default for all the production artifacts.
Issues Resolved
https://build.ci.opensearch.org/blue/organizations/jenkins/distribution-validation/detail/distribution-validation/2808/pipeline
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.