-
Notifications
You must be signed in to change notification settings - Fork 312
[AUTO] Update input manifests #5709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5709 +/- ##
==========================================
+ Coverage 96.55% 96.57% +0.01%
==========================================
Files 404 404
Lines 18424 18506 +82
==========================================
+ Hits 17790 17872 +82
Misses 634 634 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jenkins/check-for-build.jenkinsfile
Outdated
} | ||
triggers { | ||
parameterizedCron ''' | ||
H 1 * * * %INPUT_MANIFEST=3.3.0/opensearch-dashboards-3.3.0.yml;TARGET_JOB_NAME=distribution-build-opensearch-dashboards;BUILD_PLATFORM=linux windows;BUILD_DISTRIBUTION=tar rpm deb zip;TEST_MANIFEST=3.3.0/opensearch-dashboards-3.3.0-test.yml;TEST_PLATFORM=linux;TEST_DISTRIBUTION=tar;UPDATE_GITHUB_ISSUE=false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added UPDATE_GITHUB_ISSUE=false
I believe it is better to enable once we are close to the release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you update check-for-build to have this parameter available?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Via automation: NO! Will add this once this is functional. Just worried we might forget to remove this and then maintainers might complain about the failures not being reported. WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can revisit this later. Removing it for now. Creating issues because version increment is not merged might also force people to take action.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, thanks.
Signed-off-by: opensearch-ci <[email protected]>
e48a264
to
10ed7c7
Compare
Signed-off-by: Sayali Gaikawad <[email protected]> Signed-off-by: Sayali Gaikawad <[email protected]>
Signed-off-by: Sayali Gaikawad <[email protected]> Signed-off-by: Sayali Gaikawad <[email protected]>
I have noticed that a repo has incremented a version. This change updates the corresponding input manifests.