Skip to content

Conversation

peterzhuamazon
Copy link
Member

Description

Onboarding 11.0.1 lib to opensearch build repo

Issues Resolved

#5535

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Sep 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.56%. Comparing base (ec52ddc) to head (dee6c27).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5725   +/-   ##
=======================================
  Coverage   96.56%   96.56%           
=======================================
  Files         404      404           
  Lines       18440    18440           
=======================================
  Hits        17806    17806           
  Misses        634      634           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@gaiksaya gaiksaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a bit concerned about the huge bumps for promotion workflows. If possible can you please cross check with associated build-lib in those jenkinsfile and see if anything major changes?

* compatible open source license.
*/

lib = library(identifier: 'jenkins@1.0.4', retriever: modernSCM([
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huge bump for promotion. Wondering if this would break any other repo workflows. Example, parameters upgrade, etc

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since test didnt change I think we are ok with the bump tho.
Those files havent change in over 10 versions so the code is pretty much the same.
Better bump now instead of lagging behind too long.

* compatible open source license.
*/

lib = library(identifier: 'jenkins@5.11.1', retriever: modernSCM([
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above

@peterzhuamazon peterzhuamazon merged commit e307940 into opensearch-project:main Sep 18, 2025
15 checks passed
@github-project-automation github-project-automation bot moved this from 👀 In Review to ✅ Done in Engineering Effectiveness Board Sep 18, 2025
@peterzhuamazon peterzhuamazon deleted the 1password-lib-updates branch September 18, 2025 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

2 participants