-
Notifications
You must be signed in to change notification settings - Fork 312
Onboarding 11.0.1 lib to opensearch build repo #5725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Onboarding 11.0.1 lib to opensearch build repo #5725
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5725 +/- ##
=======================================
Coverage 96.56% 96.56%
=======================================
Files 404 404
Lines 18440 18440
=======================================
Hits 17806 17806
Misses 634 634 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Peter Zhu <[email protected]>
714b17b
to
dee6c27
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a bit concerned about the huge bumps for promotion workflows. If possible can you please cross check with associated build-lib in those jenkinsfile and see if anything major changes?
* compatible open source license. | ||
*/ | ||
|
||
lib = library(identifier: 'jenkins@1.0.4', retriever: modernSCM([ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huge bump for promotion. Wondering if this would break any other repo workflows. Example, parameters upgrade, etc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since test didnt change I think we are ok with the bump tho.
Those files havent change in over 10 versions so the code is pretty much the same.
Better bump now instead of lagging behind too long.
* compatible open source license. | ||
*/ | ||
|
||
lib = library(identifier: 'jenkins@5.11.1', retriever: modernSCM([ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above
Description
Onboarding 11.0.1 lib to opensearch build repo
Issues Resolved
#5535
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.