Add default values as per description #5747
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sayali Gaikawad <[email protected]>
gaiksaya
requested review from
Divyaasm,
peterzhuamazon,
prudhvigodithi,
rishabh6788,
tianleh and
zelinh
as code owners
rishabh6788
approved these changes
Oct 1, 2025
github-project-automation
bot
moved this to 👀 In Review
in Engineering Effectiveness Board
rishabh6788
reviewed
Oct 1, 2025
| description: 'Max number of tokens to use for supplied model id, defaults to 2000', | ||
| trim: true | ||
| trim: true, | ||
| defaultValue: 2000 |
There was a problem hiding this comment.
make it 4000 to be on the safer side.
There was a problem hiding this comment.
This would per stage https://build.ci.opensearch.org/blue/organizations/jenkins/release-notes-generate/detail/release-notes-generate/23/pipeline/72 is that okay?
Signed-off-by: Sayali Gaikawad <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5747 +/- ##
=======================================
Coverage 96.57% 96.57%
=======================================
Files 405 405
Lines 18506 18506
=======================================
Hits 17872 17872
Misses 634 634 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
github-project-automation
bot
moved this from 👀 In Review
to ✅ Done
in Engineering Effectiveness Board
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add default values as per description for release notes
Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.