Modify save search test to include testing query and filter - #1670
Open
abbyhu2000 wants to merge 2 commits into
Open
Modify save search test to include testing query and filter#1670abbyhu2000 wants to merge 2 commits into
abbyhu2000 wants to merge 2 commits into
Conversation
abbyhu2000
requested review from
CCongWang,
Hailong-am,
SuZhou-Joe,
ananzh,
ashwin-pc,
kavilla,
ohltyler,
peterzhuamazon,
prudhvigodithi,
raintygao,
ruanyl,
tianleh,
wanglam,
xluo-aws,
yubonluo,
yujin-emma and
zhongnansu
as code owners
December 19, 2024 05:58
abbyhu2000
force-pushed
the
better_save_search_test
branch
from
December 19, 2024 05:59
a81b7ee to
d090345
Compare
ananzh
approved these changes
Dec 21, 2024
| it('load save search should show save search name in breadcrumb', function () { | ||
| it('load save search should show save search name in breadcrumb, and show the correct query and filter', function () { | ||
| // Change time filter to something other than default time filter | ||
| const fromTime = 'Sep 20, 2015 @ 00:00:00.000'; |
Member
There was a problem hiding this comment.
nit: shall we move fromTime and toTime to constants ?
wanglam
approved these changes
Jan 13, 2025
raintygao
approved these changes
Feb 12, 2025
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Current save search test does not test on the persistence of query and filter when saving with save search. The PR modifies those tests to include testing on query and filter with save search.
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.