Skip to content

[Backport main] Improve the assertion in left navigation recent history test to avoid flakiness #1719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Backport main] Improve the assertion in left navigation recent history test to avoid flakiness #1719

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions .../core-opensearch-dashboards/opensearch-dashboards/left-navigation/left_navigation.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,11 +267,13 @@ describe('Left navigation menu', () => {

// open recent history dialog
cy.get('.headerRecentItemsButton').should('exist').click();
cy.get('div[role="dialog"]').within(() => {
// dialog displays correct visited content
cy.contains(/Recent assets/).should('exist');
cy.contains(visualizationName).should('exist');
});
cy.get('div[role="dialog"][data-autofocus="true"]')
.should('have.class', 'euiPanel')
.within(() => {
// dialog displays correct visited content
cy.contains(/Recent assets/).should('exist');
cy.contains(visualizationName).should('exist');
});

// back to dashboard
cy.get('.left-navigation-wrapper').within(() => {
Expand All @@ -283,10 +285,14 @@ describe('Left navigation menu', () => {
// wait for the page to be loaded
cy.get('.application').should('exist');
cy.get('.headerRecentItemsButton--loadingIndicator').should('not.exist');
// wait for the dashboards list loaded, avoid flaky loading icon
cy.getElementByTestId('dashboardLandingPage').within(() => {
cy.get('.euiBasicTable .euiTableRow').should('exist');
});

// open recent history dialog again
cy.get('.headerRecentItemsButton').should('exist').click();
cy.get('div[role="dialog"]').within(() => {
cy.get('div[role="dialog"][data-autofocus="true"]').within(() => {
// click recent visited visualization in the dialog
cy.contains(visualizationName).should('exist').click({ force: true });
});
Expand Down
Loading