[Banner Plugin] Cypress e2e tests for banner plugin - #1820
Conversation
Signed-off-by: Sid Wang <sidwang@amazon.com>
Signed-off-by: Sid Wang <sidwang@amazon.com>
Signed-off-by: Sid Wang <sidwang@amazon.com>
sidwang42
changed the title
1456618 to
b77cbda
Compare
Signed-off-by: Sid Wang <sidwang@amazon.com>
yujin-emma
left a comment
yujin-emma
left a comment
There was a problem hiding this comment.
LGTM, thanks for the hard work
zhongnansu
left a comment
zhongnansu
left a comment
There was a problem hiding this comment.
Core plugins tests should be under this path similar to data-source-management plugin, could you check and move? Also if you moved there, will it be picked up automatically by any existing github action workflow?
https://github.com/opensearch-project/opensearch-dashboards-functional-test/tree/main/cypress/integration/core-opensearch-dashboards/opensearch-dashboards/datasource-management-plugin
Signed-off-by: Sid Wang <sidwang@amazon.com>
Signed-off-by: Sid Wang <sidwang@amazon.com>
Signed-off-by: Sid Wang <sidwang@amazon.com>
| export const BANNER_TIMEOUT = 60000; | ||
|
|
||
| export const BANNER_SELECTORS = { | ||
| BANNER_CONTAINER: '#pluginGlobalBanner', |
There was a problem hiding this comment.
I see in this PR you are switching to use class instead of id, once that's merged, do you need update here? opensearch-project/OpenSearch-Dashboards#10324 (review)
Signed-off-by: Sid Wang <sidwang@amazon.com>
Signed-off-by: Sid Wang <sidwang@amazon.com>
zhongnansu
left a comment
zhongnansu
left a comment
There was a problem hiding this comment.
lgtm, merge after CI is passing
Signed-off-by: Sid Wang <sidwang@amazon.com>
3 participants
Description
Add end to end testing for the banner plugin.
Screenshot
Passing the tests locally:
Issues Resolved
#1813
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.