Decouple connector creation for FF tests - #1821
Merged
Merged
Conversation
ohltyler
requested review from
CCongWang,
Hailong-am,
SuZhou-Joe,
ananzh,
ashwin-pc,
kavilla,
peterzhuamazon,
prudhvigodithi,
raintygao,
ruanyl,
tianleh,
wanglam,
xluo-aws,
yubonluo,
yujin-emma and
zhongnansu
as code owners
August 5, 2025 20:17
ohltyler
force-pushed
the
ff-improvements
branch
from
August 5, 2025 20:24
4512257 to
81b30c3
Compare
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
ohltyler
force-pushed
the
ff-improvements
branch
from
August 5, 2025 20:24
81b30c3 to
f10bc22
Compare
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
dbwiddis
approved these changes
Aug 6, 2025
zhongnansu
approved these changes
Aug 6, 2025
wanglam
approved these changes
Aug 7, 2025
Signed-off-by: Tyler Ohlsen <ohltyler@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Improves the Flow Framework OSD plugin tests by decoupling the connector creation step for improved flexibility & less flakiness when running the tests against different endpoints with different security standards. For example, an Amazon OpenSearch Service (AOS) domain prohibits remote connector creation, so these tests cannot run out-of-the-box against such endpoints. This fixes that, by mocking the connector creation entirely if the step fails.
Includes several other minor improvements to minimize flakiness, such as the model deployment call and scoped-down mocking checks during ingest and search.
Tested against local domain with no security, and against an AOS domain with basic auth. Both scenarios succeed without any changes to the test file:
Issues Resolved
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.