Requery visualization context menu button - #2051
Merged
gaiksaya merged 6 commits intoJun 5, 2026
Merged
Conversation
Signed-off-by: Jackie Han <hnyng@amazon.com>
jackiehanyang
requested review from
CCongWang,
Hailong-am,
Maosaic,
SuZhou-Joe,
abbyhu2000,
ananzh,
angle943,
ashwin-pc,
kavilla,
ohltyler,
peterzhuamazon,
prudhvigodithi,
ruanyl,
sejli,
wanglam,
xluo-aws,
yubonluo,
yujin-emma and
zhongnansu
as code owners
June 5, 2026 22:15
Signed-off-by: Jackie Han <hnyng@amazon.com>
Signed-off-by: Jackie Han <hnyng@amazon.com>
Signed-off-by: Jackie Han <hnyng@amazon.com>
Signed-off-by: Jackie Han <hnyng@amazon.com>
Signed-off-by: Jackie Han <hnyng@amazon.com>
gaiksaya
approved these changes
Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This follow-up targets the Jenkins failure in
view_anomaly_events_spec.js.The Jenkins result XML showed the detached DOM error at
cypress/utils/dashboards/vis-augmenter/commands.js:15, insideopenVisContextMenu(). The previous fix re-queried menu items after opening the context menu, butopenVisContextMenu()still chainedcy.wrap(panel).find(...).click(), which can detach before the click in the Jenkins environment.This change re-queries the context menu button from the document using the visualization panel title before clicking, avoiding the stale subject chain that Jenkins reported.
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.