Fix filter_editor combo box assertion for Cypress 13 - #2062
Merged
gaiksaya merged 1 commit intoJun 8, 2026
Conversation
Cypress 13 reads the full accessible text of combo box elements (including aria labels and screen reader text) rather than just the visible value. Change 'have.text' to 'contain.text' so the assertion matches the visible value within the full text content. Signed-off-by: Justin Kim <jungkm@amazon.com>
angle943
requested review from
CCongWang,
Hailong-am,
Maosaic,
SuZhou-Joe,
abbyhu2000,
ananzh,
ashwin-pc,
kavilla,
ohltyler,
peterzhuamazon,
prudhvigodithi,
ruanyl,
sejli,
wanglam,
xluo-aws,
yubonluo,
yujin-emma and
zhongnansu
as code owners
June 8, 2026 21:04
gaiksaya
approved these changes
Jun 8, 2026
1 task
peterzhuamazon
added a commit
that referenced
this pull request
Jun 9, 2026
* Skip flaky searchOnPageLoad test in discover.spec.js (#2058) Signed-off-by: Justin Kim <jungkm@amazon.com> * Fix filter_editor combo box assertion for Cypress 13 (#2062) Signed-off-by: Justin Kim <jungkm@amazon.com> * [3.7] Update windows and linux to have different llm js startup/stop scripts (#2063) Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> * Make sure libssl curl is used to handle pem (#2064) Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> --------- Signed-off-by: Justin Kim <jungkm@amazon.com> Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> Co-authored-by: Justin Kim <jungkm@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix
filter_editor.spec.jstest failure caused by Cypress 13 reading full accessible text from combo box elements.The test asserts
have.textexpecting justextension.raw, but Cypress 13 now returns the full accessible text including aria labels:Changed to
contain.textwhich correctly matches the visible value within the full text content.Issues Resolved
Unblocks 3.7.0 release - ci-group-8 nosec filter_editor failure.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.