[3.7] Make sure certs files are used as files on Windows - #2064
Merged
peterzhuamazon merged 1 commit intoJun 9, 2026
Conversation
peterzhuamazon
added
enhancement
peterzhuamazon
requested review from
CCongWang,
kavilla and
ohltyler
as code owners
June 8, 2026 23:04
peterzhuamazon
requested review from
Hailong-am,
Maosaic,
SuZhou-Joe,
abbyhu2000,
ananzh,
angle943,
ashwin-pc,
prudhvigodithi,
ruanyl,
sejli,
wanglam,
xluo-aws,
yubonluo,
yujin-emma and
zhongnansu
as code owners
June 8, 2026 23:04
github-project-automation
Bot
moved this to Backlog
in OpenSearch Engineering Effectiveness
peterzhuamazon
moved this from Backlog
to In review
in OpenSearch Engineering Effectiveness
peterzhuamazon
marked this pull request as draft
June 8, 2026 23:05
peterzhuamazon
marked this pull request as ready for review
June 9, 2026 00:53
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
peterzhuamazon
force-pushed
the
add-spec-retries
branch
from
June 9, 2026 00:55
5984dd0 to
ef21910
Compare
gaiksaya
approved these changes
Jun 9, 2026
github-project-automation
Bot
moved this from 👀 In Review
to ✅ Done
in Engineering Effectiveness Board
github-project-automation
Bot
moved this from In review
to Done
in OpenSearch Engineering Effectiveness
1 task
peterzhuamazon
added a commit
that referenced
this pull request
Jun 9, 2026
* Skip flaky searchOnPageLoad test in discover.spec.js (#2058) Signed-off-by: Justin Kim <jungkm@amazon.com> * Fix filter_editor combo box assertion for Cypress 13 (#2062) Signed-off-by: Justin Kim <jungkm@amazon.com> * [3.7] Update windows and linux to have different llm js startup/stop scripts (#2063) Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> * Make sure libssl curl is used to handle pem (#2064) Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> --------- Signed-off-by: Justin Kim <jungkm@amazon.com> Signed-off-by: Peter Zhu <zhujiaxi@amazon.com> Co-authored-by: Justin Kim <jungkm@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
[3.7] Make sure certs files are used as files on Windows
mingw curl and libssl curl are very different in handling certs
Schannel (Windows native TLS): Uses the Windows certificate store and only accepts PKCS#12 (.pfx/.p12) files for client certificates. PEM files are not supported because Windows' crypto APIs don't parse that format.
LibreSSL/OpenSSL (cross-platform TLS): Reads PEM files directly — this is the standard format for certificates and private keys on Linux/macOS and what most tools (including OpenSearch security plugin) generate by default.
Issues Resolved
https://ci.opensearch.org/ci/dbc/integ-test-opensearch-dashboards/3.7.0/8924/windows/x64/zip/test-results/8615/integ-test/assistantDashboards/with-security/stdout.txt
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.