Skip to content

[Backport 2.19] Onboard new backport-pr re-usable github workflow (opensearch-dashboards-functional-test) - #2084

Merged
peterzhuamazon merged 1 commit into
opensearch-project:2.19from
peterzhuamazon:backport/update-backport-workflow-2.19
Jul 14, 2026
Merged

[Backport 2.19] Onboard new backport-pr re-usable github workflow (opensearch-dashboards-functional-test)#2084
peterzhuamazon merged 1 commit into
opensearch-project:2.19from
peterzhuamazon:backport/update-backport-workflow-2.19

Conversation

@peterzhuamazon

Copy link
Copy Markdown
Member

Description

Backport of #2074 to 2.19 branch.

Onboard new backport-pr re-usable github workflow (opensearch-dashboards-functional-test)

Issues Resolved

opensearch-project/opensearch-build#6270

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…rds-functional-test)

- Replace old backport workflow with reusable workflow from opensearch-build
- Remove obsolete backport-related workflows

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
@github-actions

Copy link
Copy Markdown

PR Code Analyzer ❗

AI-powered 'Code-Diff-Analyzer' found issues on commit 0d70185.

PathLineSeverityDescription
.github/workflows/backport.yml12highReusable workflow referenced at mutable '@main' tag instead of a pinned commit hash: 'opensearch-project/opensearch-build/.github/workflows/backport-pr.yml@main'. Any future commit to that branch automatically changes the code executed here, creating a supply chain attack vector. The previous actions in this file were pinned to specific commit SHAs — this regression removes that protection.
.github/workflows/backport.yml14highOPENSEARCH_CI_BOT_TOKEN secret is passed to an externally-controlled reusable workflow pinned at a mutable '@main' reference. If the upstream 'opensearch-build' repository is ever compromised or the 'main' branch modified, the called workflow gains full access to this privileged token and could exfiltrate it. The 'pull_request_target' trigger (which runs with repository secrets even for fork PRs) amplifies this risk.

The table above displays the top 10 most important findings.

Total: 2 | Critical: 0 | High: 2 | Medium: 0 | Low: 0


Pull Requests Author(s): Please update your Pull Request according to the report above.

Repository Maintainer(s): You can bypass diff analyzer by adding label skip-diff-analyzer after reviewing the changes carefully, then re-run failed actions. To re-enable the analyzer, remove the label, then re-run all actions.


⚠️ Note: The Code-Diff-Analyzer helps protect against potentially harmful code patterns. Please ensure you have thoroughly reviewed the changes beforehand.

Thanks.

@peterzhuamazon peterzhuamazon added the enhancement New feature or request label Jun 30, 2026
@peterzhuamazon peterzhuamazon moved this from Backlog to In review in OpenSearch Engineering Effectiveness Jun 30, 2026
@peterzhuamazon peterzhuamazon added the skip-diff-analyzer Maintainer to skip code-diff-analyzer check, after reviewing issues in AI analysis. label Jun 30, 2026
@peterzhuamazon

peterzhuamazon commented Jun 30, 2026

Copy link
Copy Markdown
Member Author

Expected bump and new added workflows.

@github-actions

Copy link
Copy Markdown

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

🧪 No relevant tests
🔒 No security concerns identified
✅ No TODO sections
🔀 No multiple PR themes
⚡ No major issues detected

@peterzhuamazon
peterzhuamazon merged commit 167076f into opensearch-project:2.19 Jul 14, 2026
47 of 49 checks passed
@github-project-automation github-project-automation Bot moved this from 👀 In Review to ✅ Done in Engineering Effectiveness Board Jul 14, 2026
@peterzhuamazon
peterzhuamazon deleted the backport/update-backport-workflow-2.19 branch July 14, 2026 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request skip-diff-analyzer Maintainer to skip code-diff-analyzer check, after reviewing issues in AI analysis.

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

2 participants