Skip to content

[Backport 3.8] Fix reportsDashboards edit spec flakiness with API intercepts #2118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rishabh6788 merged 1 commit into from
Jul 27, 2026
Merged

[Backport 3.8] Fix reportsDashboards edit spec flakiness with API intercepts #2118

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
102 changes: 58 additions & 44 deletions cypress/integration/plugins/reports-dashboards/02-edit.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,58 @@

import { BASE_PATH, TIMEOUT } from '../../../utils/constants';

const REPORT_DEFINITION_API = '**/api/reporting/reportDefinitions/**';

const setupEditIntercepts = () => {
cy.intercept('GET', REPORT_DEFINITION_API).as('getReportDefinition');

cy.intercept('PUT', REPORT_DEFINITION_API, (req) => {
req.headers['origin'] = BASE_PATH;
if (
req.body &&
req.body.report_params &&
req.body.report_params.core_params
) {
req.body.report_params.core_params.origin = BASE_PATH;
}
}).as('updateReportDefinition');
};

const openEditPage = () => {
cy.get('#reportDefinitionDetailsLink').first().click({ force: true });

cy.get('#editReportDefinitionButton', { timeout: TIMEOUT }).should('exist');
cy.get('#editReportDefinitionButton').click();

cy.url().should('include', 'edit');

cy.wait('@getReportDefinition', { timeout: TIMEOUT });

cy.get('#reportSettingsName', { timeout: TIMEOUT })
.should('exist')
.and(($el) => {
expect($el.val()).to.not.equal('');
});
};

const clickSaveChanges = () => {
cy.get('#editReportDefinitionButton')
.contains('Save Changes')
.trigger('mouseover')
.click({ force: true });

cy.wait('@updateReportDefinition', { timeout: TIMEOUT })
.its('response.statusCode')
.should('eq', 200);

// check that re-direct to home page
cy.get('#reportDefinitionDetailsLink', { timeout: TIMEOUT }).should('exist');
};

describe('Cypress', () => {
beforeEach(() => {
setupEditIntercepts();

// Wait before visiting to allow index refresh after previous test's save
cy.wait(5000);
cy.visit(`${BASE_PATH}/app/reports-dashboards#/`, {
Expand All @@ -29,12 +79,7 @@ describe('Cypress', () => {
});

it('Visit edit page, update name and description', () => {
cy.get('#reportDefinitionDetailsLink').first().click({ force: true });

cy.get('#editReportDefinitionButton').should('exist');
cy.get('#editReportDefinitionButton').click();

cy.url().should('include', 'edit');
openEditPage();

// update the report name
cy.get('#reportSettingsName').type('{selectall}{backspace} update name');
Expand All @@ -44,61 +89,30 @@ describe('Cypress', () => {
'{selectall}{backspace} update description'
);

cy.get('#editReportDefinitionButton')
.contains('Save Changes')
.trigger('mouseover')
.click({ force: true });

// check that re-direct to home page
cy.get('#reportDefinitionDetailsLink', { timeout: TIMEOUT }).should(
'exist'
);
clickSaveChanges();
});

it('Visit edit page, change report trigger', () => {
cy.get('#reportDefinitionDetailsLink').first().click();

cy.get('#editReportDefinitionButton').should('exist');
cy.get('#editReportDefinitionButton').click();

cy.url().should('include', 'edit');
openEditPage();

cy.get('#reportDefinitionTriggerTypes > div:nth-child(2)').click({
force: true,
});

cy.get('#Schedule').check({ force: true });
cy.get('#editReportDefinitionButton')
.contains('Save Changes')
.trigger('mouseover')
.click({ force: true });
cy.get('#Schedule').check({ force: true }).should('be.checked');

// check that re-direct to home page
cy.get('#reportDefinitionDetailsLink', { timeout: TIMEOUT }).should(
'exist'
);
clickSaveChanges();
});

it('Visit edit page, change report trigger back', () => {
cy.get('#reportDefinitionDetailsLink').first().click();

cy.get('#editReportDefinitionButton').should('exist');
cy.get('#editReportDefinitionButton').click();

cy.url().should('include', 'edit');
openEditPage();

cy.get('#reportDefinitionTriggerTypes > div:nth-child(1)').click({
force: true,
});

cy.get('#editReportDefinitionButton')
.contains('Save Changes')
.trigger('mouseover')
.click({ force: true });
cy.get('#On\\ demand').check({ force: true }).should('be.checked');

// check that re-direct to home page
cy.get('#reportDefinitionDetailsLink', { timeout: TIMEOUT }).should(
'exist'
);
clickSaveChanges();
});
});
Loading