Fix alerting dashboards tests failing with security enabled - #2120
Merged
Conversation
vikhy-aws
requested review from
CCongWang,
Hailong-am,
Maosaic,
SuZhou-Joe,
abbyhu2000,
ananzh,
angle943,
ashwin-pc,
kavilla,
ohltyler,
peterzhuamazon,
prudhvigodithi,
ruanyl,
sejli,
wanglam,
xluo-aws,
yubonluo,
yujin-emma and
zhongnansu
as code owners
July 28, 2026 20:53
Replace 'Select clusters' with 'Select data' as the page-load wait assertion. 'Select clusters' is only rendered when cross-cluster monitoring is enabled AND the user has remote index permissions. In the with-security test config, the test user lacks these permissions, so the CrossClusterConfiguration component never renders. 'Select data' is the DataSource panel title which is always present regardless of security configuration or cross-cluster settings. Resolves opensearch-project/alerting-dashboards-plugin#1492 Signed-off-by: Vikhyat Khare <kvikhy@amazon.com> Signed-off-by: vikhy-aws <191836418+vikhy-aws@users.noreply.github.com>
PR Reviewer Guide 🔍(Review updated until commit 429cb26)Here are some key observations to aid the review process:
|
|
Persistent review updated to latest commit 429cb26 |
peterzhuamazon
approved these changes
Jul 28, 2026
peterzhuamazon
pushed a commit
that referenced
this pull request
Jul 28, 2026
…2121) Replace 'Select clusters' with 'Select data' as the page-load wait assertion. 'Select clusters' is only rendered when cross-cluster monitoring is enabled AND the user has remote index permissions. In the with-security test config, the test user lacks these permissions, so the CrossClusterConfiguration component never renders. 'Select data' is the DataSource panel title which is always present regardless of security configuration or cross-cluster settings. Resolves opensearch-project/alerting-dashboards-plugin#1492 (cherry picked from commit 6279b15) Signed-off-by: Vikhyat Khare <kvikhy@amazon.com> Signed-off-by: vikhy-aws <191836418+vikhy-aws@users.noreply.github.com> Signed-off-by: opensearch-ci-bot <opensearch-infra@amazon.com> Co-authored-by: Sai Vikhyath Kudhroli <191836418+vikhy-aws@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replace 'Select clusters' with 'Select data' as the page-load wait assertion. 'Select clusters' is only rendered when cross-cluster monitoring is enabled AND the user has remote index permissions. In the with-security test config, the test user lacks these permissions, so the CrossClusterConfiguration component never renders.
'Select data' is the DataSource panel title which is always present regardless of security configuration or cross-cluster settings.
Issues Resolved
Resolves opensearch-project/alerting-dashboards-plugin#1492
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.