Fix alerting dashboards multi-index update tests failing without security - #2125
Merged
Conversation
…rity
Break the Cypress command chain between .type() and .trigger('blur') in
the "to have multiple indices" tests. Typing {enter} into the index
combo box triggers a React re-render that detaches the input element,
causing the chained .trigger('blur') to fail with a stale DOM reference.
Re-querying the element with cy.get('#index') after the type command
ensures Cypress operates on the newly-rendered input.
Resolves opensearch-project/alerting-dashboards-plugin#1492
Signed-off-by: Vikhyat Khare <kvikhy@amazon.com>
vikhy-aws
requested review from
CCongWang,
Hailong-am,
Maosaic,
SuZhou-Joe,
abbyhu2000,
ananzh,
angle943,
ashwin-pc,
kavilla,
ohltyler,
peterzhuamazon,
prudhvigodithi,
ruanyl,
sejli,
wanglam,
xluo-aws,
yubonluo,
yujin-emma and
zhongnansu
as code owners
July 30, 2026 18:07
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
peterzhuamazon
approved these changes
Jul 30, 2026
peterzhuamazon
merged commit Jul 30, 2026
46edba2
into
opensearch-project:main
56 of 66 checks passed
peterzhuamazon
pushed a commit
that referenced
this pull request
Jul 30, 2026
…rity (#2125) (#2126) Break the Cypress command chain between .type() and .trigger('blur') in the "to have multiple indices" tests. Typing {enter} into the index combo box triggers a React re-render that detaches the input element, causing the chained .trigger('blur') to fail with a stale DOM reference. Re-querying the element with cy.get('#index') after the type command ensures Cypress operates on the newly-rendered input. Resolves opensearch-project/alerting-dashboards-plugin#1492 (cherry picked from commit 46edba2) Signed-off-by: Vikhyat Khare <kvikhy@amazon.com> Signed-off-by: opensearch-ci-bot <opensearch-infra@amazon.com> Co-authored-by: Sai Vikhyath Kudhroli <191836418+vikhy-aws@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Break the Cypress command chain between .type() and .trigger('blur') in the "to have multiple indices" tests. Typing {enter} into the index combo box triggers a React re-render that detaches the input element, causing the chained .trigger('blur') to fail with a stale DOM reference.
Re-querying the element with cy.get('#index') after the type command ensures Cypress operates on the newly-rendered input.
Issues Resolved
Resolves opensearch-project/alerting-dashboards-plugin#1492
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.