Fix alerting dashboards multi-index update tests failing - #2129
Merged
Conversation
vikhy-aws
requested review from
CCongWang,
Hailong-am,
Maosaic,
SuZhou-Joe,
abbyhu2000,
ananzh,
angle943,
ashwin-pc,
kavilla,
ohltyler,
peterzhuamazon,
prudhvigodithi,
ruanyl,
sejli,
wanglam,
xluo-aws,
yubonluo,
yujin-emma and
zhongnansu
as code owners
August 1, 2026 08:47
Signed-off-by: vikhy-aws <191836418+vikhy-aws@users.noreply.github.com>
PR Reviewer Guide 🔍(Review updated until commit 0c79fd8)Here are some key observations to aid the review process:
|
|
Persistent review updated to latest commit 0c79fd8 |
peterzhuamazon
approved these changes
Aug 1, 2026
peterzhuamazon
merged commit Aug 1, 2026
744b2dc
into
opensearch-project:main
55 of 64 checks passed
peterzhuamazon
pushed a commit
that referenced
this pull request
Aug 1, 2026
(cherry picked from commit 744b2dc) Signed-off-by: vikhy-aws <191836418+vikhy-aws@users.noreply.github.com> Signed-off-by: opensearch-ci-bot <opensearch-infra@amazon.com> Co-authored-by: Sai Vikhyath Kudhroli <191836418+vikhy-aws@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The "to have multiple indices" tests in
bucket_level_monitor_spec.jsandquery_level_monitor_spec.jsfail because:cy.get('#index').click()triggers an async fetch (/api/alerting/remote/indexes) that causes a React re-render, detaching the DOM element before.type()can execute.{enter}within.type()also triggers a re-render that detaches the input element mid-command.The fix breaks the chained Cypress command into separate
cy.get('#index')calls for each operation (click, type index-a, type index-b, blur). This forces Cypress to re-query the DOM between each step, ensuring the element is always attached.Issues resolved
Fixes opensearch-project/alerting-dashboards-plugin#1492
Testing
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.