chore(build): upgrade Go to v1.24 + replace golang.org/x/exp/slices usage with standard lib's
#674
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: hainenber <[email protected]>
Signed-off-by: hainenber <[email protected]>
hainenber
requested review from
Jakob3xD,
VachaShah,
VijayanB and
dblock
as code owners
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #674 +/- ##
==========================================
+ Coverage 57.29% 60.28% +2.99%
==========================================
Files 315 377 +62
Lines 9823 11684 +1861
==========================================
+ Hits 5628 7044 +1416
- Misses 2902 3205 +303
- Partials 1293 1435 +142
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
I think the failed integration tests were due to flakiness? It seems odd to have older version compatibility tests succeeded (2.3, 2.4 for example) whilst newer didn't 🤔 |
Signed-off-by: hainenber <[email protected]>
zvone10
approved these changes
Jul 2, 2025
|
Rebase? |
Signed-off-by: hainenber <[email protected]>
|
Rebased :D |
dblock
approved these changes
Jul 5, 2025
|
LGTM, see why integ tests failed? |
|
I think it's the flakiness again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe what this change achieves.
Upgrade minimum Go version to 1.24 to gain some small performance enhancements in 1.22, 1.23 and 1.24
Remove external usage of
golang.org/x/expwith Go's standard libraryslices.Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
N/A
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.