Skip to content

Conversation

rehanpfmr
Copy link
Contributor

@rehanpfmr rehanpfmr commented Apr 15, 2025

Description

Describe what this change achieves.

Issues Resolved

Closes #683

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Rehan Pasha <[email protected]>
Copy link

codecov bot commented Apr 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 14.83%. Comparing base (06a6dc8) to head (58b8141).
Report is 89 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (06a6dc8) and HEAD (58b8141). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (06a6dc8) HEAD (58b8141)
integration 1 0
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #693       +/-   ##
===========================================
- Coverage   57.29%   14.83%   -42.46%     
===========================================
  Files         315      316        +1     
  Lines        9823    10354      +531     
===========================================
- Hits         5628     1536     -4092     
- Misses       2902     8736     +5834     
+ Partials     1293       82     -1211     
Flag Coverage Δ
integration ?
unit 14.83% <ø> (+1.98%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
opensearchapi/api_cat-plugins.go 0.00% <ø> (-100.00%) ⬇️

... and 303 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: rehanpfmr <[email protected]>
Signed-off-by: rehanpfmr <[email protected]>
@Jakob3xD
Copy link
Collaborator

Removing the omitempty option results in description being always present. Instead of removing it, we might want to consider changing the type to a pointer string.

Copy link
Collaborator

@Jakob3xD Jakob3xD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing the omitempty option results in description being always present. Instead of removing it, we might want to consider changing the type to a pointer string.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Can't create policy with empty description

2 participants