Skip to content

Opensearch go update deps - #831

Merged
Jakob3xD merged 4 commits into
opensearch-project:mainfrom
sean-:opensearch-go-update-deps
May 5, 2026
Merged

Opensearch go update deps#831
Jakob3xD merged 4 commits into
opensearch-project:mainfrom
sean-:opensearch-go-update-deps

Conversation

@sean-

@sean- sean- commented May 4, 2026

Copy link
Copy Markdown
Collaborator

Summary

Routine dependency updates.

golang.org/x/sync v0.19.0 -> v0.20.0

  • Mechanical interface{} -> any rename (semantically identical since Go 1.18)
  • Doc typo fix in errgroup
  • Go directive bumped to 1.25.0
  • No behavioral changes, no new dependencies

golang.org/x/mod v0.33.0 -> v0.35.0

  • Zero source code changes between versions
  • Only go.mod metadata updates (go directive to 1.25.0, golang.org/x/tools bumped)
  • All commits by Gopher Robot (official Go project automation)

github.com/wI2L/jsondiff v0.7.0 -> v0.7.1

  • Bug fix: factorization was dropping operations when JSON Pointer paths share a string prefix (e.g. /key/b vs /key/bb). Root cause: bare strings.HasPrefix without checking for / path boundary. Fixed with hasProperPathPrefix().
  • Feature: adds MergePatch / MergePatchJSON for RFC 7386 JSON Merge Patch generation (stdlib-only, uses encoding/json)
  • No new dependencies added

github.com/aws/aws-sdk-go-v2 v1.41.1 -> v1.41.7

  • Security fix (v1.41.4): Strip X-Amz-Security-Token header on HTTP redirect to a different host. Prevents credential leakage when a redirect crosses trust boundaries. Correctly scoped to cross-host 307/308 redirects only.
  • Bug fix (v1.41.5): Clock skew could persist on the client even after the server clock realigned. Now uses atomic.Int64 for skew state with proper healing on realignment.
  • Go modernization (interface{} -> any, ioutil -> modern stdlib)
  • Eventstream: replaced panic() with error returns for unknown header types (robustness)

github.com/aws/aws-sdk-go-v2/config v1.32.7 -> v1.32.17

  • Dependency-only bumps (lockstep with core SDK releases)

github.com/aws/aws-sdk-go-v2/credentials v1.19.7 -> v1.19.16

  • Dependency-only bumps (lockstep with core SDK releases)

github.com/aws/smithy-go v1.24.0 -> v1.25.1

  • Bug fix (v1.25.1): Memory leak in LRU cache. Put() with an existing key allocated a new list entry without removing the old one. Now updates in place and moves to front.
  • Feature (v1.25.0): Endpoint BDD (binary decision diagram) evaluator for more efficient endpoint resolution
  • Feature (v1.24.1): Middleware helpers to store/retrieve event stream output from Metadata
  • Bug fix (v1.24.3): Additional SigV4 configuration (DisableUnsignedPayloadSentinel, CanonicalTimeFormat) for CodeCommit Git HTTPS signing

New transitive dependency: github.com/aws/aws-sdk-go-v2/internal/v4a v1.4.24

  • SigV4A (asymmetric) signing using ECDSA P-256, derived from standard AWS credentials via NIST-800-108 KDF
  • Pulled in because STS v1.42.1 now advertises SchemeIDSigV4A alongside SigV4
  • Uses only Go stdlib crypto (crypto/ecdsa, crypto/elliptic, crypto/hmac, crypto/sha256)
  • No external dependencies beyond aws-sdk-go-v2 internal modules and smithy-go
  • First-party AWS module in the aws/aws-sdk-go-v2 monorepo

Fixes: #805
Fixes: #806
Fixes: #807

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

sean- added 4 commits May 4, 2026 09:39
Mechanical modernization only: replaces interface{} with any,
fixes an errgroup doc typo, bumps go directive to 1.25.0.
Zero behavioral changes.

Signed-off-by: Sean Chittenden <sean.chittenden@crowdstrike.com>
No source code changes between these versions. Only go.mod
metadata: go directive bumped to 1.25.0 and golang.org/x/tools
updated (both by Gopher Robot).

Signed-off-by: Sean Chittenden <sean.chittenden@crowdstrike.com>
Bug fix: factorization was dropping operations when JSON Pointer
paths share a string prefix (e.g. /key/b vs /key/bb). Now checks
path boundary at '/' separator. Also adds MergePatch (RFC 7386)
generation support (stdlib-only, no new dependencies).

Signed-off-by: Sean Chittenden <sean.chittenden@crowdstrike.com>
Notable changes across the AWS SDK + smithy-go dependency tree:

aws-sdk-go-v2 core:
- Fix: strip X-Amz-Security-Token header on cross-host redirect
- Fix: clock skew no longer persists after client/server realign

smithy-go v1.24.0 -> v1.25.1:
- Fix: LRU cache memory leak (existing keys leaked list entries)
- Feature: endpoint BDD trait support
- Feature: additional SigV4 configuration knobs

New transitive dep: internal/v4a v1.4.24 (SigV4A asymmetric
signing, pulled by STS v1.42.1 which now advertises SigV4A).
Uses only Go stdlib crypto primitives.

Signed-off-by: Sean Chittenden <sean.chittenden@crowdstrike.com>
@codecov

codecov Bot commented May 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.87%. Comparing base (1dbe719) to head (55cb54e).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #831      +/-   ##
==========================================
- Coverage   72.90%   72.87%   -0.04%     
==========================================
  Files         428      428              
  Lines       15647    15647              
==========================================
- Hits        11408    11403       -5     
- Misses       2600     2604       +4     
- Partials     1639     1640       +1     
Flag Coverage Δ
integration 65.71% <ø> (-0.04%) ⬇️
unit 43.62% <ø> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Jakob3xD
Jakob3xD merged commit 225ceda into opensearch-project:main May 5, 2026
78 checks passed
@sean-
sean- deleted the opensearch-go-update-deps branch May 5, 2026 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants